Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump @metamask/queued-request controller to ^2.0.0 to fix confirmation popup focus in request queue #25497

Merged

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jun 24, 2024

Description

Open in GitHub Codespaces

Related issues

See: MetaMask/core#4457
See: #25397

Manual testing steps

  1. Ensure request queue is toggled on
  2. In Tab 1, Visit the test dapp
  3. run await window.ethereum.request({method: 'wallet_switchEthereumChain', params: [{"chainId": "0xaa36a7"}]}) in console to change the network to sepolia for this dapp
  4. In Tab 2, Visit a different dapp
  5. run await window.ethereum.request({method: 'wallet_switchEthereumChain', params: [{"chainId": "1"}]}) in console to change the network to mainnet for this dapp
  6. In Tab 1, click the Send Transaction button, but ignore the confirmation notification (leave it open)
  7. In Tab 2, run await window.ethereum.request({method: 'eth_requestAccounts'})
  8. The confirmation notification window should be focused and visible now, but still be displaying the pending transaction from before

Screenshots/Recordings

Before

After

Screen.Recording.2024-06-24.at.2.22.07.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Jun 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/queued-request-controller@2.0.0 None +9 851 kB

🚮 Removed packages: npm/@metamask/queued-request-controller@1.0.0

View full report↗︎

@jiexi jiexi marked this pull request as ready for review June 24, 2024 22:07
@jiexi jiexi requested a review from a team as a code owner June 24, 2024 22:07
@jiexi jiexi requested review from adonesky1 and darkwing June 24, 2024 22:12
digiwand
digiwand previously approved these changes Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (7add8ac) to head (f96d58e).

Current head f96d58e differs from pull request most recent head 718dd6f

Please upload reports for the commit 718dd6f to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25497   +/-   ##
========================================
  Coverage    69.65%   69.65%           
========================================
  Files         1347     1347           
  Lines        47805    47803    -2     
  Branches     13186    13184    -2     
========================================
- Hits         33297    33296    -1     
+ Misses       14508    14507    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [f96d58e]
Page Load Metrics (48 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61948284
domContentLoaded9131011
load39584853
domInteractive9131011
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 333 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jiexi jiexi merged commit cc8adbd into develop Jun 25, 2024
69 of 70 checks passed
@jiexi jiexi deleted the jl/bump-queued-request-controller-fix-confirmation-popup-focus branch June 25, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ddb1787]
Page Load Metrics (42 ± 1 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint59857473
domContentLoaded8121010
load38484231
domInteractive8121010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 333 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants