fix(22851): check if active device to prevent autoconnect for hw

[Akaryatrh]

Description

There was an issue where the selected device was kept "unlocked" by keyring controller. Then, the following logic was always redirecting to the selected device "page" and was connecting again to the previously unlocked hardware device:
https://github.com/MetaMask/metamask-extension/blob/develop/ui/pages/create-account/connect-hardware/index.js#L135-L139

      const unlocked = await this.props.checkHardwareStatus(device, path);
      if (unlocked) {
        this.setState({ unlocked: true });
        this.getPage(device, 0, path);
      }

To fix this, I simply checked if a device was active or not. Tested on Ledger, Trezor and QR based wallets

Related issues

Fixes: #22851

Manual testing steps

1. From account list, click on "add account or hardware wallet"
2. then click on "add hardware wallet"
3. select a hardware wallet
4. Wait for the pop up for HID access (if you use the Trezor simulator, you can close the pop-up)
5. Click cancel or select an account (and add it). You should be redirected to device selection.
6. Click on account
7. Add hardware wallet
8. You should now be able to select again the device you want (while before last active device was automatically selected and user redirected to account selection)

Screenshots/Recordings

Before

Enregistrement.de.l.ecran.2024-06-25.a.14.14.10.mov

After

Enregistrement.de.l.ecran.2024-06-25.a.14.09.34.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [712d03e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (132 ± 177 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	107	81	11	5
		domContentLoaded	9	21	11	4	2
		load	39	1738	132	368	177
		domInteractive	9	21	11	4	2

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 19 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (9760248) to head (712d03e).
Report is 9 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25503   +/-   ##
========================================
  Coverage    69.64%   69.65%           
========================================
  Files         1345     1345           
  Lines        47789    47789           
  Branches     13179    13179           
========================================
+ Hits         33282    33283    +1     
+ Misses       14507    14506    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hjetpoluru]

LGTM