fix: do not use STX for swap+send approval

[BZahory]

Description

Paired w/ @dan437 and @forest-diggs-consensys

We removed STX functionality for Swap+Send in #25422. However, we still get the STX flow because the swapApproval type we use is still routed as an STX.

Since only Swap+Send uses the swapApproval type for STXs routed through submitSmartTransactionHook, we can exclude it in the same way we excluded the swapAndSend type in #25422.

Related issues

Fixes: #25356

Manual testing steps

1. Enable Smart Transactions in settings
2. Switch to Ethereum Mainnet
3. Submit a swap+send transaction that requires an approval (i.e. from an ERC-20 w/o an existing approval)
4. Ensure that the STX screen does not show after submitting
5. Ensure that the contract interaction isn't marked as "unapproved"

Screenshots/Recordings

Before

Screen.Recording.2024-06-25.at.12.16.52.PM.mov

After

Screen.Recording.2024-06-25.at.12.13.25.PM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.65%. Comparing base (1cc54f6) to head (84c5f98).

Files	Patch %	Lines
app/scripts/lib/transaction/smart-transactions.ts	66.67%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25510      +/-   ##
===========================================
- Coverage    69.65%   69.65%   -0.00%     
===========================================
  Files         1347     1347              
  Lines        47803    47805       +2     
  Branches     13184    13186       +2     
===========================================
+ Hits         33296    33297       +1     
- Misses       14507    14508       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [84c5f98]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (139 ± 185 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	181	86	23	11
		domContentLoaded	9	23	13	4	2
		load	41	1818	139	385	185
		domInteractive	9	23	13	4	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 53 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)