Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for Snackbar component #25515

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jun 25, 2024

Description

This pull request adds a Storybook story for the Snackbar component in the MetaMask extension repository. The story is created to test the Snackbar component in isolation and ensure it renders correctly in the Storybook UI.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

  1. Go to the latest build of Storybook in this PR.
  2. Navigate to the Snackbar component in the Components/UI folder.

Screenshots/Recordings

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Link to Devin run: https://preview.devin.ai/devin/5be2ff2370a84b619ee0027d9cbca344
Requested by: the user

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot added the area-documentation Issues relating to documentation, in the codebase and off. label Jun 26, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 15, 2024
@georgewrmarshall georgewrmarshall requested a review from a team July 15, 2024 17:38
@@ -23,6 +23,7 @@ const account = {
...mockState.metamask.internalAccounts.accounts[
'cf8dace4-9439-4bd4-b3a8-88c821c8fcb3'
],
balance: '0x0', // Ensure balance is defined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
balance: '0x0', // Ensure balance is defined

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert back and remove these changes. They don't seem to apply to the purpose of this PR of adding the Snackbar story file

Copy link

sonarcloud bot commented Jul 25, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [dd2d645]
Page Load Metrics (393 ± 316 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint703071175426
domContentLoaded98829199
load402027393658316
domInteractive98829199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (98d792f) to head (dd2d645).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25515   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1405     1405           
  Lines        49733    49733           
  Branches     13751    13751           
========================================
  Hits         34651    34651           
  Misses       15082    15082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 25, 2024 15:47
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 25, 2024 15:47
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • checked storybook ✅

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request introduces a Storybook story for the Snackbar component to facilitate isolated testing and ensure proper rendering.

  • Added ui/components/ui/snackbar/snackbar.stories.tsx to create a Storybook story for the Snackbar component.
  • The story allows customizable props for className and content, enhancing the development workflow by providing a visual testing environment.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@garrettbear garrettbear merged commit bd45d11 into develop Jul 25, 2024
78 of 79 checks passed
@garrettbear garrettbear deleted the devin/story-c4f2b0 branch July 25, 2024 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-documentation Issues relating to documentation, in the codebase and off. external-contributor release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants