-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create a story for Snackbar component #25515
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -23,6 +23,7 @@ const account = { | |||
...mockState.metamask.internalAccounts.accounts[ | |||
'cf8dace4-9439-4bd4-b3a8-88c821c8fcb3' | |||
], | |||
balance: '0x0', // Ensure balance is defined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
balance: '0x0', // Ensure balance is defined |
ui/ducks/index.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert back and remove these changes. They don't seem to apply to the purpose of this PR of adding the Snackbar story file
35410d6
to
cfae41f
Compare
Quality Gate passedIssues Measures |
Builds ready [dd2d645]
Page Load Metrics (393 ± 316 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25515 +/- ##
========================================
Coverage 69.67% 69.67%
========================================
Files 1405 1405
Lines 49733 49733
Branches 13751 13751
========================================
Hits 34651 34651
Misses 15082 15082 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- checked storybook ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request introduces a Storybook story for the Snackbar
component to facilitate isolated testing and ensure proper rendering.
- Added
ui/components/ui/snackbar/snackbar.stories.tsx
to create a Storybook story for theSnackbar
component. - The story allows customizable props for
className
andcontent
, enhancing the development workflow by providing a visual testing environment.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Description
This pull request adds a Storybook story for the
Snackbar
component in the MetaMask extension repository. The story is created to test theSnackbar
component in isolation and ensure it renders correctly in the Storybook UI.Related issues
N/A
Manual testing steps
Snackbar
component in theComponents/UI
folder.Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
Link to Devin run: https://preview.devin.ai/devin/5be2ff2370a84b619ee0027d9cbca344
Requested by: the user