-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support multichain in blockexplorer and qr code #25526
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
9e0a145
to
edcc72c
Compare
f4d0246
to
5280b97
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25526 +/- ##
===========================================
+ Coverage 69.60% 69.65% +0.05%
===========================================
Files 1364 1365 +1
Lines 48173 48185 +12
Branches 13291 13293 +2
===========================================
+ Hits 33527 33559 +32
+ Misses 14646 14626 -20 ☔ View full report in Codecov by Sentry. |
Builds ready [6fa8eed]
Page Load Metrics (49 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [6d9cf20]
Page Load Metrics (63 ± 8 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/app/modals/confirm-remove-account/confirm-remove-account.test.js
Outdated
Show resolved
Hide resolved
ui/components/multichain/menu-items/view-explorer-menu-item.test.tsx
Outdated
Show resolved
Hide resolved
ui/components/app/modals/nickname-popovers/nickname-popovers.component.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Builds ready [848b52a]
Page Load Metrics (253 ± 245 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Quality Gate passedIssues Measures |
Builds ready [0df3873]
Page Load Metrics (363 ± 325 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - manual tested it
Screen.Recording.2024-07-02.at.11.10.52.AM.mov
Verified on Chrome Version 128.0.6613.120 25526-eth-test-chrome.movBitcoin Case ✅ 25526-btc-test-chrome.movVerified on Firefox 129.0.2 25526-eth-test-firefox.movBitcoin Case ✅ 25526-btc-test-firefox.mov |
Description
This PR updates the block explorer to support non-EVM explorers and fixes the QR code to also display non-EVM accounts.
Related issues
Fixes https://github.com/MetaMask/accounts-planning/issues/489
Manual testing steps
EVM
View on Explorer
ethereum:
prefixedNon-EVM
View on Explorer
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist