fix: support multichain in blockexplorer and qr code #25526

montelaidev · 2024-06-26T14:41:53Z

Description

This PR updates the block explorer to support non-EVM explorers and fixes the QR code to also display non-EVM accounts.

Related issues

Fixes https://github.com/MetaMask/accounts-planning/issues/489

Manual testing steps

EVM

Click on global menu and click on View on Explorer
See that the user goes to etherscan
Click on the account details
Click on copy address to clipboard and verify that the address is a 0x prefixed.
Verify QR code is also ethereum: prefixed

Non-EVM

Create a BTC account
Click on global menu and click on View on Explorer
See that the user goes to blockstream.io
Click on the account details
Click on copy address to clipboard and verify that the address is not 0x prefixed.
Verify QR code is only the btc address

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-26T14:42:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…count

codecov · 2024-06-27T08:13:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (4886a3f) to head (0df3873).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25526      +/-   ##
===========================================
+ Coverage    69.60%   69.65%   +0.05%     
===========================================
  Files         1364     1365       +1     
  Lines        48173    48185      +12     
  Branches     13291    13293       +2     
===========================================
+ Hits         33527    33559      +32     
+ Misses       14646    14626      -20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-27T08:25:23Z

Builds ready [6fa8eed]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (49 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	104	81	10	5
		domContentLoaded	9	13	10	1	1
		load	41	63	49	7	3
		domInteractive	9	13	10	1	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.46 KiB (0.05%)
common: 160 Bytes (0.00%)

metamaskbot · 2024-06-28T08:02:53Z

Builds ready [6d9cf20]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (63 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	119	90	18	8
		domContentLoaded	9	57	21	12	6
		load	39	91	63	16	8
		domInteractive	9	57	21	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.46 KiB (0.05%)
common: 160 Bytes (0.00%)

shared/constants/multichain/networks.ts

test/e2e/tests/dapp-interactions/block-explorer.spec.js

ui/helpers/utils/multichain/blockExplorer.ts

ui/components/app/modals/confirm-remove-account/confirm-remove-account.test.js

ui/components/multichain/menu-items/view-explorer-menu-item.test.tsx

ui/components/multichain/menu-items/view-explorer-menu-item.tsx

ui/helpers/utils/multichain/blockExplorer.ts

ui/components/app/modals/nickname-popovers/nickname-popovers.component.js

ui/helpers/utils/multichain/blockExplorer.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ui/helpers/utils/multichain/blockExplorer.ts

ui/store/store.ts

ui/components/multichain/menu-items/view-explorer-menu-item.tsx

…renamed

metamaskbot · 2024-06-28T13:30:30Z

Builds ready [848b52a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (253 ± 245 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	180	115	27	13
		domContentLoaded	11	71	33	16	8
		load	44	1869	253	509	245
		domInteractive	11	71	33	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.34 KiB (0.05%)
common: 160 Bytes (0.00%)

shared/constants/multichain/networks.ts

ui/selectors/multichain.ts

ui/helpers/utils/multichain/blockExplorer.ts

ui/helpers/utils/multichain/blockExplorer.test.ts

ui/components/ui/qr-code-view/qr-code-view.test.tsx

ui/components/multichain/menu-items/view-explorer-menu-item.tsx

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

ui/helpers/utils/multichain/blockExplorer.ts

ui/selectors/multichain.ts

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

sonarcloud · 2024-07-02T12:29:01Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-02T12:56:46Z

Builds ready [0df3873]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (363 ± 325 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	286	118	45	22
		domContentLoaded	9	88	31	20	10
		load	49	2402	363	677	325
		domInteractive	9	88	31	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.02 KiB (0.04%)
common: 160 Bytes (0.00%)

gantunesr

LGTM - manual tested it

Screen.Recording.2024-07-02.at.11.10.52.AM.mov

k-g-j · 2024-09-03T16:33:24Z

Verified on Chrome Version 128.0.6613.120
Ethereum Case ✅

25526-eth-test-chrome.mov

Bitcoin Case ✅

25526-btc-test-chrome.mov

Verified on Firefox 129.0.2
Ethereum Case ✅

25526-eth-test-firefox.mov

Bitcoin Case ✅

25526-btc-test-firefox.mov

montelaidev changed the title ~~Fix/qr and blockexplore for multichain~~ fix: support multichain in blockexplorer and qr code Jun 26, 2024

montelaidev added the team-accounts label Jun 26, 2024

montelaidev self-assigned this Jun 26, 2024

montelaidev force-pushed the fix/qr-and-blockexplore-for-multichain branch from 9e0a145 to edcc72c Compare June 26, 2024 15:43

montelaidev added 12 commits June 27, 2024 09:43

fix: fix addresses in qr

0f6a897

feat: support multichain blockexplorer

6a2bec9

fix: update confirm remove account to support non evm accounts

4d109ee

fix: update util

6bdfe81

fix: nickname popover test

27afed2

refactor: use InternalAccountPropType

2b73a65

fix: test

0fc049a

fix: account link

87a440d

fix: update snapshot

191a362

fix: test

5b09f95

fix: checksum

2165ef0

fix: update getMultichainAccountLink to receive address instead of ac…

5280b97

…count

montelaidev force-pushed the fix/qr-and-blockexplore-for-multichain branch from f4d0246 to 5280b97 Compare June 27, 2024 07:44

fix: lint

6fa8eed

montelaidev marked this pull request as ready for review June 27, 2024 08:18

montelaidev requested a review from a team as a code owner June 27, 2024 08:18

Merge branch 'develop' into fix/qr-and-blockexplore-for-multichain

6d9cf20

ccharly reviewed Jun 28, 2024

View reviewed changes

Apply suggestions from code review

a129a3b

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

gantunesr reviewed Jun 28, 2024

View reviewed changes

ui/helpers/utils/multichain/blockExplorer.ts Show resolved Hide resolved

ui/store/store.ts Show resolved Hide resolved

ui/components/multichain/menu-items/view-explorer-menu-item.tsx Show resolved Hide resolved

montelaidev added 2 commits June 28, 2024 20:34

fix: getMultichainBlockExplorerUrl and getMultichainAccountUrl being …

6fb9da4

…renamed

fix: import

f9a075b

fix: add test

848b52a

montelaidev added 2 commits July 2, 2024 00:28

Merge branch 'develop' into fix/qr-and-blockexplore-for-multichain

d5e3768

Merge branch 'develop' into fix/qr-and-blockexplore-for-multichain

befb7c9

montelaidev requested review from ccharly and gantunesr July 2, 2024 01:29

ccharly reviewed Jul 2, 2024

View reviewed changes

montelaidev and others added 3 commits July 2, 2024 16:10

Apply suggestions from code review

431f190

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

fix: remove should

292260e

fix: use explorer url from config.

aeb00ea

ccharly reviewed Jul 2, 2024

View reviewed changes

ui/helpers/utils/multichain/blockExplorer.ts Outdated Show resolved Hide resolved

ui/selectors/multichain.ts Outdated Show resolved Hide resolved

montelaidev and others added 3 commits July 2, 2024 20:18

Update ui/helpers/utils/multichain/blockExplorer.ts

41cd387

Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

fix: casing

47cd8ec

Merge branch 'develop' into fix/qr-and-blockexplore-for-multichain

0df3873

ccharly approved these changes Jul 2, 2024

View reviewed changes

gantunesr approved these changes Jul 2, 2024

View reviewed changes

montelaidev merged commit dfad34b into develop Jul 2, 2024
73 checks passed

montelaidev deleted the fix/qr-and-blockexplore-for-multichain branch July 2, 2024 15:27

github-actions bot locked and limited conversation to collaborators Jul 2, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: support multichain in blockexplorer and qr code #25526

fix: support multichain in blockexplorer and qr code #25526

montelaidev commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024

codecov bot commented Jun 27, 2024 •

edited

Loading

metamaskbot commented Jun 27, 2024

metamaskbot commented Jun 28, 2024

metamaskbot commented Jun 28, 2024

sonarcloud bot commented Jul 2, 2024

metamaskbot commented Jul 2, 2024

gantunesr left a comment

k-g-j commented Sep 3, 2024

fix: support multichain in blockexplorer and qr code #25526

fix: support multichain in blockexplorer and qr code #25526

Conversation

montelaidev commented Jun 26, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jun 26, 2024

codecov bot commented Jun 27, 2024 • edited Loading

Codecov Report

metamaskbot commented Jun 27, 2024

metamaskbot commented Jun 28, 2024

metamaskbot commented Jun 28, 2024

sonarcloud bot commented Jul 2, 2024

Quality Gate passed

metamaskbot commented Jul 2, 2024

gantunesr left a comment

Choose a reason for hiding this comment

k-g-j commented Sep 3, 2024

montelaidev commented Jun 26, 2024 •

edited

Loading

codecov bot commented Jun 27, 2024 •

edited

Loading