-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: UX: Multichain: Add test for mutiple dapp confirmation order #25536
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [1e5b508]
Page Load Metrics (49 ± 5 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25536 +/- ##
========================================
Coverage 69.70% 69.70%
========================================
Files 1349 1349
Lines 47864 47864
Branches 13205 13205
========================================
Hits 33360 33360
Misses 14504 14504 ☔ View full report in Codecov by Sentry. |
Builds ready [c438f40]
Page Load Metrics (46 ± 4 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you add these scenarios on test coverage sheet and fill the version when e2e tests are added so we can track? Thanks !
Description
This PR ensures no dapp-specified transactions get dropped when triggering transactions on dapps, switching to a dapp on another chain, and triggering another transaction.
Related issues
Supercedes: #25459
Fixes:
Manual testing steps
Tab 1
, connect toUniswap
onEthereum Mainnet
Tab 2
, connect toPancakeSwap
onBNB Chain
Tab 3
, connect toTest Dapp
onSepolia
Tab 1
andTab 2
BUT DO NOT CONFIRM IT, JUST MOVE ON TO THE NEXT TABTab 3
BUT DO NOT CONFIRM ITTab 1
(Uniswap
) onEthereum Mainnet
; confirm or reject it. See the confirmation window closePancakeSwap
/Tab 2
confirmation onBNB
chain; confirm or reject it. See the confirmation window closeTab 3
/Test Dapp
send onSepolia
. Confirm or reject it.Screenshots/Recordings
Before
After
Video of equivalent, manual test of this E2E
https://github.com/MetaMask/metamask-extension/assets/46655/cc4578f9-602c-4c2e-835d-79e4ca8ed762
Pre-merge author checklist
Pre-merge reviewer checklist