-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump assets controller to v34.0.0 #25540
Merged
plasmacorral
merged 12 commits into
develop
from
bump-assets-and-transaction-controllers
Jun 28, 2024
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fde8380
chore(deps): bump assets and transaction controller
montelaidev c9d40f2
revert: deleted test
montelaidev 4b0ea16
fix: dedupe
montelaidev 3940779
fix: update policy
montelaidev eeacdbe
Merge remote-tracking branch 'origin/develop' into bump-assets-and-tr…
montelaidev 2456040
Update LavaMoat policies
metamaskbot 5914acc
fix: revert transaction controller bump
montelaidev cf9dbd7
fix:test
montelaidev 463b447
Merge remote-tracking branch 'origin/develop' into bump-assets-and-tr…
montelaidev cab8736
fix: update test
montelaidev 53617fe
Merge remote-tracking branch 'origin/develop' into bump-assets-and-tr…
montelaidev 0485474
fix: update test
montelaidev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -222,11 +222,6 @@ describe('MetaMaskController', function () { | |
const decimals = 18; | ||
|
||
it('two parallel calls with same token details give same result', async function () { | ||
const supportsInterfaceStub = jest.fn().mockResolvedValue(false); | ||
jest | ||
.spyOn(metamaskController.tokensController, '_createEthersContract') | ||
.mockResolvedValue({ supportsInterface: supportsInterfaceStub }); | ||
|
||
const [token1, token2] = await Promise.all([ | ||
metamaskController.getApi().addToken({ address, symbol, decimals }), | ||
metamaskController.getApi().addToken({ address, symbol, decimals }), | ||
|
@@ -235,10 +230,6 @@ describe('MetaMaskController', function () { | |
}); | ||
|
||
it('networkClientId is used when provided', async function () { | ||
const supportsInterfaceStub = jest.fn().mockResolvedValue(false); | ||
jest | ||
.spyOn(metamaskController.tokensController, '_createEthersContract') | ||
.mockResolvedValue({ supportsInterface: supportsInterfaceStub }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No longer part of tokens controller |
||
const callSpy = jest | ||
.spyOn(metamaskController.controllerMessenger, 'call') | ||
.mockReturnValue({ configuration: { chainId: '0xa' } }); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer part of tokens controller