feat: support security alerts API #25544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25544 +/- ##
===========================================
+ Coverage 69.78% 69.79% +0.02%
===========================================
Files 1376 1377 +1
Lines 48409 48435 +26
Branches 13350 13354 +4
===========================================
+ Hits 33779 33805 +26
Misses 14630 14630 ☔ View full report in Codecov by Sentry. |
Builds ready [0fbd0e9]
Page Load Metrics (140 ± 174 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
...firmations/components/confirm/blockaid-loading-indicator/blockaid-loading-indicator.test.tsx
Outdated
Show resolved
Hide resolved
Builds ready [8fa55b3]
Page Load Metrics (184 ± 187 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/helpers/utils/metrics.test.js
Outdated
| security_alert_reason: BlockaidReason.setApprovalForAll, | ||
| security_alert_response: BlockaidResultType.Malicious, | ||
| security_alert_source: SecurityAlertSource.Local, | ||
| ui_customizations: ['flagged_as_malicious'], |
There was a problem hiding this comment.
[nit] is it worth saving this string as a constant to prevent typos?
There was a problem hiding this comment.
Great point, I changed to use the enum MetaMetricsEventUiCustomization.
pedronfigueiredo
requested changes
Jul 3, 2024
jpuri
reviewed
Jul 3, 2024
| security_alert_response: BlockaidResultType.Malicious, | ||
| ui_customizations: ['flagged_as_malicious'], | ||
| }); | ||
| expect(result).toStrictEqual(expectedMetricsPropsBase); |
matthewwalsh0
previously approved these changes
Jul 3, 2024
pedronfigueiredo
approved these changes
Jul 3, 2024
Builds ready [ba81efe]
Page Load Metrics (222 ± 211 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Jul 4, 2024
OGPoyraz
approved these changes
Jul 4, 2024
|
Builds ready [1d534ff]
Page Load Metrics (137 ± 148 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-12.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the use of the Security Alerts API to validate dApp requests, with a fallback to local PPOM validation if the API request fails.
Environment Variables
Add the following variables to
.metamaskrc:Additional Changes
Introduces the security_alert_source property to transaction and signature events, indicating api or local as the source.
Related Repository
Refer to the Security Alerts API repository for more details.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2514 https://github.com/MetaMask/MetaMask-planning/issues/2515
Manual testing steps
Test blockaid regression
add the envs
security-alertsand find the call to the API service.Existing PPOM logic should function as before, even with the above environment variables added, due to the fallback to the controller in the event of an error.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist