-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set bridge src network, tokens and top assets #26214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
micaelae
force-pushed
the
mb866-set-src-network
branch
from
July 30, 2024 01:40
5b15722
to
4889dc2
Compare
micaelae
force-pushed
the
mb866-set-dest-network
branch
from
August 6, 2024 19:56
7a8a2d6
to
6d1aa20
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
August 6, 2024 19:56
4889dc2
to
336d27d
Compare
micaelae
force-pushed
the
mb866-set-dest-network
branch
from
August 12, 2024 22:27
6d1aa20
to
db9afeb
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
August 12, 2024 22:28
336d27d
to
2ee4299
Compare
micaelae
force-pushed
the
mb866-set-dest-network
branch
from
August 14, 2024 20:52
db9afeb
to
adf90bd
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
August 14, 2024 20:54
2ee4299
to
b9ddede
Compare
micaelae
force-pushed
the
mb866-set-dest-network
branch
from
August 16, 2024 20:53
adf90bd
to
04cfd34
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
August 16, 2024 20:57
b9ddede
to
ae6f3d4
Compare
micaelae
force-pushed
the
mb866-set-dest-network
branch
from
August 16, 2024 21:29
04cfd34
to
1a893fc
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
August 16, 2024 21:48
ae6f3d4
to
76b3ba8
Compare
BZahory
reviewed
Aug 21, 2024
BZahory
approved these changes
Aug 21, 2024
micaelae
force-pushed
the
mb866-set-dest-network
branch
from
August 22, 2024 22:08
489e510
to
d9bac5b
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
August 22, 2024 22:09
76b3ba8
to
f3c85c8
Compare
ejwessel
previously approved these changes
Aug 22, 2024
micaelae
force-pushed
the
mb866-set-dest-network
branch
from
August 22, 2024 23:00
d9bac5b
to
d52197d
Compare
micaelae
force-pushed
the
mb866-set-dest-network
branch
2 times, most recently
from
September 5, 2024 22:30
84b5fb4
to
c4af120
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
September 5, 2024 22:32
f3c85c8
to
3af13d0
Compare
micaelae
force-pushed
the
mb866-set-dest-network
branch
from
October 1, 2024 01:46
0d6df16
to
2cb7625
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
October 1, 2024 01:46
4e7197c
to
eadcb8c
Compare
Builds ready [eadcb8c]
Page Load Metrics (1657 ± 59 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
martahj
reviewed
Oct 1, 2024
Builds ready [a08cbaa]
Page Load Metrics (2003 ± 134 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
force-pushed
the
mb866-set-dest-network
branch
2 times, most recently
from
October 4, 2024 16:24
d24e8b1
to
e982f17
Compare
micaelae
force-pushed
the
mb866-set-src-network
branch
from
October 4, 2024 18:08
a08cbaa
to
0adea10
Compare
Quality Gate passedIssues Measures |
martahj
approved these changes
Oct 4, 2024
Builds ready [0adea10]
Page Load Metrics (1763 ± 81 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
infiniteflower
approved these changes
Oct 4, 2024
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 4, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.7.0
Issue or pull request that will be included in release 12.7.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
selectSrcNetwork
bridge controller action, which sets a state value for the cross-chain swaps source networkuseBridging
hook within the bridge route, which sets the src network, tokens and topAssets when the bridge experience is loadedRelated issues
Fixes: https://consensyssoftware.atlassian.net/browse/METABRIDGE-866
Manual testing steps
N/A, changes only affect state and are not visible
Screenshots/Recordings
New values added to state:
Pre-merge author checklist
Pre-merge reviewer checklist