Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for external links in feature announcements #26491

Merged
merged 7 commits into from
Oct 24, 2024

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Aug 19, 2024

Description

This PR introduces support for external links in feature announcements. The following changes have been made:

  • Import TypeExternalLinkFields: Added the import statement for TypeExternalLinkFields in feature-announcements.ts.
  • Update TypeFeatureAnnouncementFields: Included the externalLink field in the TypeFeatureAnnouncementFields type.
  • Modify FeatureAnnouncementRawNotificationData: Added the externalLink field to the FeatureAnnouncementRawNotificationData type.
  • Update fetchFeatureAnnouncementNotifications: Modified the function to fetch and process the externalLink field from Contentful.
  • Update UI Components: Updated the relevant UI components to handle and display the externalLink in notifications.

Open in GitHub Codespaces

Related issues

No related issues

Manual testing steps

To test the modification, it’s necessary to create a notification on Contentful that includes both types of links.

Screenshots/Recordings

Before

Screenshot 2024-10-23 at 18 31 38

After

Screenshot 2024-10-23 at 18 33 52

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications Notifications team label Aug 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matteoscurati matteoscurati marked this pull request as ready for review August 19, 2024 10:39
@matteoscurati matteoscurati requested a review from a team as a code owner August 19, 2024 10:39
Copy link

sonarcloud bot commented Aug 19, 2024

@matteoscurati matteoscurati marked this pull request as draft August 19, 2024 11:16
@matteoscurati matteoscurati force-pushed the feat/notifications-add-external-link branch from eedc979 to e3aef95 Compare August 19, 2024 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@matteoscurati matteoscurati reopened this Aug 19, 2024
@matteoscurati
Copy link
Contributor Author

This PR should remain in Draft until the CORE repo is updated cc @Prithpal-Sooriya

@matteoscurati matteoscurati marked this pull request as ready for review October 23, 2024 10:47
@metamaskbot
Copy link
Collaborator

Builds ready [aadad00]
Page Load Metrics (2161 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint175727052169245118
domContentLoaded174926192126225108
load175827012161236114
domInteractive21102542211
backgroundConnect881362512
firstReactRender622131073014
getState592232311
initialActions00000
loadScripts12502103157020297
setupStore1386402713
uiStartup197529002405236113
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 414 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@matteoscurati matteoscurati changed the title feat: ✨ add support for external links in feature announcements feat: add support for external links in feature announcements Oct 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [fe3124c]
Page Load Metrics (1975 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17752400199215172
domContentLoaded17642229193712158
load17752298197513163
domInteractive287445136
backgroundConnect1074332211
firstReactRender502871125124
getState574242412
initialActions00000
loadScripts1303168214499445
setupStore1374352512
uiStartup19852683221816780

@metamaskbot
Copy link
Collaborator

Builds ready [71b7dc4]
Page Load Metrics (1873 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32225431721490235
domContentLoaded15882469184018689
load15992483187318890
domInteractive189645199
backgroundConnect10124342613
firstReactRender48111832010
getState65820199
initialActions01000
loadScripts11421981137616981
setupStore1169292110
uiStartup178326782068211101
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 413 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@matteoscurati matteoscurati added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@matteoscurati matteoscurati added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@matteoscurati matteoscurati added this pull request to the merge queue Oct 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2024
@matteoscurati matteoscurati added this pull request to the merge queue Oct 24, 2024
Merged via the queue into develop with commit 4fe3a9f Oct 24, 2024
76 checks passed
@matteoscurati matteoscurati deleted the feat/notifications-add-external-link branch October 24, 2024 13:17
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants