Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for external links in feature announcements #26491

Merged
merged 7 commits into from
Oct 24, 2024
Merged

feat: add support for external links in feature announcements #26491

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e979f0a
feat: :sparkles: add support for external links in feature announcements
matteoscurati Aug 19, 2024
87101f7
Merge branch 'develop' into feat/notifications-add-external-link
matteoscurati Sep 10, 2024
aadad00
Merge branch 'develop' into feat/notifications-add-external-link
matteoscurati Oct 23, 2024
fe3124c
Merge branch 'develop' into feat/notifications-add-external-link
matteoscurati Oct 23, 2024
3086732
fix: :bug: fix external link
matteoscurati Oct 24, 2024
d4f8d4f
docs: :memo: add comment
matteoscurati Oct 24, 2024
71b7dc4
Merge branch 'develop' into feat/notifications-add-external-link
matteoscurati Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ui/pages/notification-details/notification-details-footer/notification-details-footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,15 @@ export const NotificationDetailsFooter = ({
</>
)}
{footer.type === 'footer_feature_announcement' && (
<>
<Box
display={Display.Flex}
gap={4}
flexDirection={FlexDirection.Row}
width={BlockSize.Full}
>
<footer.ExternalLink notification={notification} />
<footer.ExtensionLink notification={notification} />
</>
</Box>
)}
</Box>
);
Expand Down
12 changes: 12 additions & 0 deletions ui/pages/notifications/notification-components/feature-announcement/feature-announcement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,5 +117,17 @@ export const components: NotificationComponent<FeatureAnnouncementNotification>
isExternal={true}
/>
) : null,
ExternalLink: ({ notification }) =>
notification.data.externalLink ? (
<NotificationDetailButton
notification={notification}
variant={ButtonVariant.Secondary}
text={notification.data.externalLink.externalLinkText}
href={`/${notification.data.externalLink.externalLinkUrl}`}
Prithpal-Sooriya marked this conversation as resolved.
Show resolved Hide resolved
id={notification.id}
endIconName={false}
isExternal={true}
/>
) : null,
},
};
1 change: 1 addition & 0 deletions ui/pages/notifications/notification-components/types/notifications/notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ type FooterOnChainNotification<N = Notification> = {
type FooterFeatureAnnouncement<N = Notification> = {
type: 'footer_feature_announcement';
ExtensionLink: NotificationFC<N>;
ExternalLink: NotificationFC<N>;
};

/**
Expand Down
Loading