Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump @metamask/utils from ^8.2.1 to ^9.1.0 #26551

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Aug 20, 2024

Description

Major version bump for @metamask/utils.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MajorLift MajorLift requested a review from a team August 20, 2024 19:34
@MajorLift MajorLift self-assigned this Aug 20, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift changed the title fix(deps): Bump @metamask/utils from ^8.2.1 to ^9.1.0 fix(deps): Fix implicit any typing of Infer and downstream types, bump @metamask/utils from ^8.2.1 to ^9.1.0 Aug 20, 2024

This comment was marked as resolved.

@MajorLift

This comment was marked as outdated.

@metamaskbot

This comment was marked as outdated.

@MajorLift

This comment was marked as resolved.

@MajorLift MajorLift changed the base branch from develop to bump/eth-json-rpc-provider-14.0.0 August 20, 2024 20:14
@MajorLift MajorLift added the DO-NOT-MERGE Pull requests that should not be merged label Aug 20, 2024
Copy link

socket-security bot commented Aug 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@MajorLift
Copy link
Contributor Author

@SocketSecurity ignore npm/diff@5.2.0

benign author change

@metamaskbot

This comment was marked as resolved.

@MajorLift

This comment was marked as outdated.

@metamaskbot

This comment was marked as outdated.

Base automatically changed from bump/eth-json-rpc-provider-14.0.0 to develop August 21, 2024 08:19
@MajorLift

This comment was marked as outdated.

@MajorLift MajorLift removed the DO-NOT-MERGE Pull requests that should not be merged label Aug 21, 2024
@metamaskbot

This comment was marked as outdated.

@MajorLift MajorLift marked this pull request as ready for review August 21, 2024 12:44
@MajorLift MajorLift requested review from a team as code owners August 21, 2024 12:44
@MajorLift MajorLift added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 21, 2024
@metamaskbot

This comment was marked as outdated.

legobeat
legobeat previously approved these changes Aug 29, 2024
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase with develop and conflict-resolution - LGTM otherwise

@MajorLift

This comment was marked as outdated.

@metamaskbot

This comment was marked as outdated.

@metamaskbot

This comment was marked as outdated.

@MajorLift
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@metamaskbot
Copy link
Collaborator

Builds ready [a3dbcaa]
Page Load Metrics (1813 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22122451755408196
domContentLoaded15102197179420397
load151322491813210101
domInteractive137033157
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 81.59 KiB (2.46%)
  • ui: 0 Bytes (0.00%)
  • common: -218.3 KiB (-2.70%)

Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift MajorLift requested a review from a team September 4, 2024 13:45
Copy link

sonarcloud bot commented Sep 4, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [04ef2c0]
Page Load Metrics (1861 ± 147 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24725901703559268
domContentLoaded160725821836281135
load161826071861306147
domInteractive118933199
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 81.59 KiB (2.46%)
  • ui: 0 Bytes (0.00%)
  • common: -218.3 KiB (-2.70%)

@MajorLift MajorLift merged commit 1998dc4 into develop Sep 4, 2024
84 checks passed
@MajorLift MajorLift deleted the bump/utils-9.1.0 branch September 4, 2024 14:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
@MajorLift MajorLift restored the bump/utils-9.1.0 branch October 10, 2024 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants