-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (cherry-pick): incomplete transactions on startup #26972
fix (cherry-pick): incomplete transactions on startup #26972
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
dev build 90b6406 Basic transactions functionality: cancel, speed up, custom nonce, transactions history, contract interactions, approvals, navigation between multiple transactions, gas settings, PPOM - passed Restart browser -passed STX - passed |
90b6406
to
9e5566d
Compare
No release label on PR. Adding release label release-12.3.0 on PR, as PR was added to branch 12.3.0 when release was cut. |
2 similar comments
No release label on PR. Adding release label release-12.3.0 on PR, as PR was added to branch 12.3.0 when release was cut. |
No release label on PR. Adding release label release-12.3.0 on PR, as PR was added to branch 12.3.0 when release was cut. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Builds ready [c088c9d]
Page Load Metrics (1784 ± 111 ms)
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/transaction-controller@34.0.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.3.0 #26972 +/- ##
===================================================
+ Coverage 70.24% 70.25% +0.01%
===================================================
Files 1426 1427 +1
Lines 50239 50255 +16
Branches 13954 13962 +8
===================================================
+ Hits 35289 35306 +17
+ Misses 14950 14949 -1 ☔ View full report in Codecov by Sentry. |
Builds ready [c729157]
Page Load Metrics (1798 ± 47 ms)
|
Description
Patch
TransactionController
to prevent stuck signed transactions.Specifically:
unapproved
transactions on startup.approved
andsigned
transactions on startup.See patch changes here.
Related issues
Fixes: #23361
Manual testing steps
High level regression of basic transaction functionality, and restarting browser.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist