fix: Error handling for the state log download failure #26999

NiranjanaBinoy · 2024-09-09T21:41:44Z

Description

Display error message if the exportAsFile() for state log download in advanced tab in the settings fails.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2875

Manual testing steps

Throw an error artificially in the exportAsFile() state logs download function
Failed to download state log. message is diaplayed

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-09T21:41:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-09-09T22:14:59Z

Builds ready [413f612]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1654 ± 67 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	232	1995	1520	448	215
		domContentLoaded	1449	1987	1637	140	67
		load	1458	1995	1654	140	67
		domInteractive	14	165	39	32	15

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 100 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarcloud · 2024-09-11T17:44:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-11T18:27:27Z

Builds ready [66cada3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1803 ± 115 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	241	2238	1487	620	298
		domContentLoaded	1519	2211	1783	235	113
		load	1527	2240	1803	239	115
		domInteractive	19	152	40	28	14

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 100 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-09-11T18:28:56Z

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.10%. Comparing base (a61b938) to head (66cada3).

Files with missing lines	Patch %	Lines
...es/settings/advanced-tab/advanced-tab.component.js	0.00%	4 Missing ⚠️
ui/helpers/utils/export-utils.js	50.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26999      +/-   ##
===========================================
- Coverage    70.11%   70.10%   -0.00%     
===========================================
  Files         1426     1426              
  Lines        49689    49693       +4     
  Branches     13902    13902              
===========================================
+ Hits         34835    34836       +1     
- Misses       14854    14857       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-09-18T19:55:07Z

Builds ready [a2fcbc3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1863 ± 120 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	234	2521	1638	523	251
		domContentLoaded	1555	2449	1844	250	120
		load	1564	2455	1863	249	120
		domInteractive	16	115	47	27	13

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 338 Bytes (0.00%)
common: 482 Bytes (0.01%)

metamaskbot · 2024-09-24T02:39:11Z

Builds ready [ca4bb74]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1780 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1576	2243	1783	189	91
		domContentLoaded	1558	2226	1755	188	90
		load	1597	2246	1780	186	90
		domInteractive	21	152	45	40	19

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 338 Bytes (0.00%)
common: 482 Bytes (0.01%)

metamaskbot · 2024-09-25T20:58:02Z

Builds ready [9d5ec3d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1758 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	291	2542	1619	466	224
		domContentLoaded	1581	2402	1727	169	81
		load	1591	2571	1758	199	96
		domInteractive	16	185	45	36	18

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 389 Bytes (0.01%)
common: 482 Bytes (0.01%)

ui/pages/settings/advanced-tab/advanced-tab.component.test.js

metamaskbot · 2024-09-26T21:54:01Z

Builds ready [11ba96f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1714 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	339	2081	1651	324	155
		domContentLoaded	1589	2025	1690	112	54
		load	1599	2098	1714	124	59
		domInteractive	12	93	37	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 389 Bytes (0.01%)
common: 482 Bytes (0.01%)

metamaskbot · 2024-09-30T18:25:47Z

Builds ready [3d626de]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1690 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	253	2120	1628	354	170
		domContentLoaded	1473	2023	1654	148	71
		load	1485	2164	1690	168	81
		domInteractive	18	99	39	23	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 389 Bytes (0.01%)
common: 482 Bytes (0.01%)

sonarcloud · 2024-10-15T19:22:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-15T19:43:24Z

Builds ready [5f86e1f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1901 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	537	2485	1819	335	161
		domContentLoaded	1651	2466	1863	162	78
		load	1669	2479	1901	162	78
		domInteractive	17	82	45	18	9
		backgroundConnect	7	176	42	37	18
		firstReactRender	46	195	77	35	17
		getState	5	65	30	23	11
		initialActions	0	1	0	0	0
		loadScripts	1189	2077	1400	171	82
		setupStore	11	95	29	23	11
		uiStartup	1877	2678	2110	193	93

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 389 Bytes (0.00%)
common: 489 Bytes (0.01%)

DDDDDanica · 2024-10-18T09:45:37Z

LGTM ! Let me know when u resolve the conflicts !

metamaskbot · 2024-10-18T15:46:35Z

Builds ready [6c80d61]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1975 ± 181 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1699	2947	1962	329	158
		domContentLoaded	1680	2369	1892	240	115
		load	1697	3149	1975	377	181
		domInteractive	17	140	54	30	14
		backgroundConnect	9	791	83	176	85
		firstReactRender	45	266	95	44	21
		getState	4	158	25	42	20
		initialActions	0	0	0	0	0
		loadScripts	1251	1867	1388	172	83
		setupStore	10	140	37	33	16
		uiStartup	1850	3940	2221	529	254

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 389 Bytes (0.00%)
common: 489 Bytes (0.01%)

NiranjanaBinoy added the team-extension-platform label Sep 9, 2024

NiranjanaBinoy self-assigned this Sep 9, 2024

NiranjanaBinoy requested a review from a team as a code owner September 9, 2024 21:41

NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from fda937f to 413f612 Compare September 9, 2024 21:43

NiranjanaBinoy changed the title ~~Error handling for the state log download failure~~ fix: Error handling for the state log download failure Sep 10, 2024

NiranjanaBinoy force-pushed the exportAsFile-error-handling branch 2 times, most recently from 17af50a to 66cada3 Compare September 11, 2024 17:42

NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from ded2319 to a2fcbc3 Compare September 18, 2024 19:20

NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from a2fcbc3 to ca4bb74 Compare September 24, 2024 02:07

legobeat reviewed Sep 26, 2024

View reviewed changes

ui/pages/settings/advanced-tab/advanced-tab.component.test.js Outdated Show resolved Hide resolved

ui/pages/settings/advanced-tab/advanced-tab.component.test.js Outdated Show resolved Hide resolved

legobeat requested changes Sep 26, 2024

View reviewed changes

ui/pages/settings/advanced-tab/advanced-tab.component.test.js Outdated Show resolved Hide resolved

NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from 5a5171f to 11ba96f Compare September 26, 2024 15:19

NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from 0618d42 to 3d626de Compare September 30, 2024 17:52

NiranjanaBinoy requested review from legobeat and a team September 30, 2024 20:32

NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from 3d626de to 5f86e1f Compare October 15, 2024 19:10

DDDDDanica previously approved these changes Oct 18, 2024

View reviewed changes

adding error handling for settings tab

6c80d61

NiranjanaBinoy dismissed DDDDDanica’s stale review via 6c80d61 October 18, 2024 15:12

NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from 5f86e1f to 6c80d61 Compare October 18, 2024 15:12

DDDDDanica approved these changes Oct 18, 2024

View reviewed changes

NiranjanaBinoy mentioned this pull request Oct 21, 2024

fix: Removing warning prop from settings #27990

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Error handling for the state log download failure #26999

fix: Error handling for the state log download failure #26999

NiranjanaBinoy commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024

metamaskbot commented Sep 9, 2024

sonarcloud bot commented Sep 11, 2024

metamaskbot commented Sep 11, 2024

codecov bot commented Sep 11, 2024

metamaskbot commented Sep 18, 2024

metamaskbot commented Sep 24, 2024

metamaskbot commented Sep 25, 2024

metamaskbot commented Sep 26, 2024

metamaskbot commented Sep 30, 2024

sonarcloud bot commented Oct 15, 2024

metamaskbot commented Oct 15, 2024

DDDDDanica commented Oct 18, 2024

metamaskbot commented Oct 18, 2024

fix: Error handling for the state log download failure #26999

Are you sure you want to change the base?

fix: Error handling for the state log download failure #26999

Conversation

NiranjanaBinoy commented Sep 9, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 9, 2024

metamaskbot commented Sep 9, 2024

sonarcloud bot commented Sep 11, 2024

Quality Gate passed

metamaskbot commented Sep 11, 2024

codecov bot commented Sep 11, 2024

Codecov Report

metamaskbot commented Sep 18, 2024

metamaskbot commented Sep 24, 2024

metamaskbot commented Sep 25, 2024

metamaskbot commented Sep 26, 2024

metamaskbot commented Sep 30, 2024

sonarcloud bot commented Oct 15, 2024

Quality Gate passed

metamaskbot commented Oct 15, 2024

DDDDDanica commented Oct 18, 2024

metamaskbot commented Oct 18, 2024

NiranjanaBinoy commented Sep 9, 2024 •

edited

Loading