-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow to re-submit a cancelled swap if cancelled via a HW wallet #27210
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3fcc656
to
92749ba
Compare
Builds ready [92749ba]
Page Load Metrics (1981 ± 129 ms)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.3.0 #27210 +/- ##
===================================================
+ Coverage 70.24% 70.26% +0.01%
===================================================
Files 1426 1427 +1
Lines 50239 50255 +16
Branches 13954 13963 +9
===================================================
+ Hits 35289 35307 +18
+ Misses 14950 14948 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but I'm having trouble getting 12.3 and related branches to load 🤔
No release label on PR. Adding release label release-12.3.0 on PR, as PR was added to branch 12.3.0 when release was cut. |
Description
This PR is a partial cherry pick of this one and fixes an edge case for this PR, where when a swap was cancelled on a HW device, the submit button for swaps was disabled. Now a user can resubmit cancelled swaps repeatedly.
It was already fixed here about a month ago, but it's not in the v12.3.0 release. That's why this partial cherry-pick is needed.
Manual testing steps
Swap
button should be enabledScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist