fix: Allow to re-submit a cancelled swap if cancelled via a HW wallet

[dan437]

Description

This PR is a partial cherry pick of this one and fixes an edge case for this PR, where when a swap was cancelled on a HW device, the submit button for swaps was disabled. Now a user can resubmit cancelled swaps repeatedly.

It was already fixed here about a month ago, but it's not in the v12.3.0 release. That's why this partial cherry-pick is needed.

Manual testing steps

1. Go to Swaps with a HW wallet on Ethereum Mainnet and Smart Transactions enabled in Advanced Settings
2. Submit a swap, but cancel it on a HW device
3. You should see the quote overview page again and the Swap button should be enabled

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [92749ba]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1981 ± 129 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1668	2526	1993	278	133
		domContentLoaded	1620	2513	1935	270	130
		load	1670	2525	1981	270	129
		domInteractive	20	98	39	17	8

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (439f7d6) to head (92749ba).
Report is 10 commits behind head on Version-v12.3.0.

Files with missing lines	Patch %	Lines
ui/pages/swaps/prepare-swap-page/review-quote.js	50.00%	2 Missing ⚠️
ui/ducks/swaps/swaps.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27210      +/-   ##
===================================================
+ Coverage            70.24%   70.26%   +0.01%     
===================================================
  Files                 1426     1427       +1     
  Lines                50239    50255      +16     
  Branches             13954    13963       +9     
===================================================
+ Hits                 35289    35307      +18     
+ Misses               14950    14948       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[martahj]

Code LGTM but I'm having trouble getting 12.3 and related branches to load 🤔

[metamaskbot]

No release label on PR. Adding release label release-12.3.0 on PR, as PR was added to branch 12.3.0 when release was cut.