-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove alert settings #27230
chore: remove alert settings #27230
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
5dd1080
to
6e1ec3d
Compare
48c0d13
to
1b93100
Compare
Builds ready [1ad343b]
Page Load Metrics (2033 ± 145 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
…k/metamask-extension into chore-3212-remove-alert-settings
Builds ready [4d5195e]
Page Load Metrics (1608 ± 110 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
… chore-3212-remove-alert-settings
Quality Gate passedIssues Measures |
Closing because a past commit had triggered many code owners but since had been reverted but the codeowners still persist. Recreating a new PR |
Description
The "Alerts" settings section is no longer needed and needs to be removed.
I am not sure if we should remove the Alerts controller and related redux, there may be implications we don't know of when doing so. I purpose we just remove the tests, UI and possibly creating a redux migration to reset the state to default. Create a second follow up ticket to remove the controller and related redux
Related issues
Fixes: #3212
Manual testing steps
Screenshots/Recordings
NA
Before
Menu
Search
After
Menu
Search
Pre-merge author checklist
Pre-merge reviewer checklist