Commits on Sep 24, 2024

1. fix: Don't show third party notice for preinstalled Snaps (#27319) …

   <!--
   Please submit this PR as a draft initially.
   Do not mark it as "Ready for review" until the template has been
   completely filled out, and PR status checks have passed at least once.
   -->
   
   We show a third party notice when installing or connecting to a Snap for
   the first time. Preinstalled Snaps are first party Snaps however, so we
   don't need to show the warning for these Snaps. I've implemented some
   logic that checks if the requested Snap is a preinstalled Snap, and only
   show the third party notice if it's not.
   
   [![Open in GitHub
   Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27319?quickstart=1)
   
   Fixes: MetaMask/MetaMask-planning#3325.
   
   Assuming you have not accepted the third party notice before:
   
   1. Go to [the Test Snaps
   page](https://metamask.github.io/snaps/test-snaps/latest/)
   2. Connect to the preinstalled Snap, and verify the notice is _not_
   shown
   3. Connect to any other Snap, and verify that the notice _is_ shown
   
   - [x] I've followed [MetaMask Contributor
   Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
   Extension Coding
   Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
   - [x] I've completed the PR template to the best of my ability
   - [ ] I’ve included tests if applicable
   - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
   if applicable
   - [x] I’ve applied the right labels on the PR (see [labeling
   guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
   Not required for external contributors.
   
   - [ ] I've manually tested the PR (e.g. pull and build branch, run the
   app, test code being changed).
   - [ ] I confirm that this PR addresses all acceptance criteria described
   in the ticket it closes and includes the necessary testing evidence such
   as recordings and or screenshots.

   

   Mrtenz committed Sep 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for b030733
   • Browse repository at this point

   Copy the full SHA

   b030733 View commit details

   Browse the repository at this point in the history