cherry-pick: remove methods from array used to determine which requests should be enqueued because they can be safely passed through (#27315)

[adonesky1]

Fix issues that arise when a STX is initated in a dapp and subsequent method calls were being unnecessarily queued until the STX was complete.

The following methods can be safely removed from the list of methods we use to determine whether a request should be queued or executed immediately:

• 'wallet_addEthereumChain'
• 'wallet_requestPermissions',
• 'wallet_requestSnaps',
• 'eth_decrypt',
• 'eth_requestAccounts',
• 'eth_getEncryptionPublicKey',

Fixes: #27098

1. Make sure you have STX enabled from settings
2. Navigate to https://docs.metamask.io/wallet/reference/eth_sendtransaction/
3. Connect the wallet and switch networks to Sepolia
4. Trigger a TX (call run request)
5. Confirm the transaction and see the STX pending screen
6. Go to test dapp
7. Click Connect --> this needs to happen while STX is pending
8. See that you are able to connect

Before-wallet_requestSnaps.mov

wallet_requestPermissions:

Screen.Recording.2024-09-20.at.1.11.57.PM.mov

wallet_requestSnaps

Screen.Recording.2024-09-20.at.1.41.04.PM.mov

eth_requestAccounts

Screen.Recording.2024-09-20.at.1.14.44.PM.mov

wallet_addEthereumChain

Screen.Recording.2024-09-20.at.1.01.45.PM.mov

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding
  Standards.

• I've completed the PR template to the best of my ability

• I’ve included tests if applicable

• I’ve documented my code using JSDoc format if applicable

• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (439f7d6) to head (3e5fc36).
Report is 22 commits behind head on Version-v12.3.0.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27373      +/-   ##
===================================================
- Coverage            70.24%   70.14%   -0.10%     
===================================================
  Files                 1426     1432       +6     
  Lines                50239    50430     +191     
  Branches             13954    13989      +35     
===================================================
+ Hits                 35289    35371      +82     
- Misses               14950    15059     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [3e5fc36]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1706 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1553	2103	1711	113	54
		domContentLoaded	1536	2005	1671	96	46
		load	1555	2111	1706	117	56
		domInteractive	15	62	32	11	5

[metamaskbot]

No release label on PR. Adding release label release-12.3.0 on PR, as PR was cherry-picked in branch 12.3.0.