-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "Dapp viewed Event @no-mmi is sent when refreshing da..." flaky test #27381
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
8b9e72c
to
631fb41
Compare
d8d3152
to
54a2429
Compare
… fix-flaky-test-dapp-viewed-26899
Quality Gate passedIssues Measures |
Builds ready [4c8a9a0]
Page Load Metrics (1863 ± 67 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!
LGTM ! |
Description
In this test, there are two different requests for the "Dapp Viewed" event: one with the property is_first_visit: true and the other with is_first_visit: false. However, the current mock setup does not differentiate between these two requests.
To ensure that both "Dapp Viewed" event requests are properly handled, we need to create two separate mocks has been created.
Special thanks to @seaona for her thorough analysis and understanding of this tricky flaky test. Her insights and proposed solution were instrumental in resolving this issue. All credit for identifying and addressing this problem goes to her.
Related issues
Fixes:
#24655
#24651
#26899
Manual testing steps
Run the dapp viewed spec locally or in codespace using below commands against chrome browser:
yarn
yarn build:test:webpack
ENABLE_MV3=false yarn test:e2e:single test/e2e/tests/metrics/dapp-viewed.spec.js --browser=chrome
Pre-merge author checklist
Pre-merge reviewer checklist