Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isPermitSignatureRequest logic. Do not display as Permit if spender is not present #27384

Closed
wants to merge 9 commits into from
Closed

fix: isPermitSignatureRequest logic. Do not display as Permit if spender is not present #27384

wants to merge 9 commits into from

Commits on Sep 25, 2024

  1. fix: hide Spender if no "spender" is found

    @digiwand
    digiwand committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c0487d6 View commit details
    Browse the repository at this point in the history

  2. chore: add permit spender comments

    @digiwand
    digiwand committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e732e66 View commit details
    Browse the repository at this point in the history

  3. refactor: isPermitSignatureRequest logic

    @digiwand
    digiwand committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d19d8ca View commit details
    Browse the repository at this point in the history

  4. Revert "fix: hide Spender if no "spender" is found" 

    This reverts commit c0487d6.
    @digiwand
    digiwand committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7cd71ee View commit details
    Browse the repository at this point in the history

  5. test: add isPermitSignatureRequest test cases

    @digiwand
    digiwand committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1a5a784 View commit details
    Browse the repository at this point in the history

  6. fix: reduce isPermitSignatureRequest checks 

    e.g. owner and value will not exist if it is a Permit2 request.
    @digiwand
    digiwand committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    53c9923 View commit details
    Browse the repository at this point in the history

  7. test: rm irrelevant tests

    @digiwand
    digiwand committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    016e7b2 View commit details
    Browse the repository at this point in the history

  8. style: destruct parseTypedDataMessage

    @digiwand
    digiwand committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    876f27d View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. chore: update comment

    @digiwand
    digiwand committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    14be86e View commit details
    Browse the repository at this point in the history