-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preferences controller to base controller v2 #27398
Merged
kanthesha
merged 64 commits into
develop
from
feat/preferences-controller-to-base-controller-v2
Oct 14, 2024
Merged
feat: preferences controller to base controller v2 #27398
kanthesha
merged 64 commits into
develop
from
feat/preferences-controller-to-base-controller-v2
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [efda3a4]
Page Load Metrics (1908 ± 175 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [51e8886]
Page Load Metrics (1771 ± 60 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
7 tasks
Builds ready [9d9291f]
Page Load Metrics (1843 ± 110 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mikesposito
reviewed
Sep 26, 2024
mikesposito
reviewed
Sep 26, 2024
Builds ready [0eb3dc5]
Page Load Metrics (1832 ± 90 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
… feat/preferences-controller-to-base-controller-v2
…ithub.com:MetaMask/metamask-extension into feat/preferences-controller-to-base-controller-v2
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 14, 2024
kanthesha
dismissed stale reviews from cryptodev-2s, mikesposito, and DDDDDanica
via
October 14, 2024 14:52
e0f925e
DDDDDanica
approved these changes
Oct 14, 2024
cryptodev-2s
approved these changes
Oct 14, 2024
Builds ready [e0f925e]
Page Load Metrics (1883 ± 138 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2024
Quality Gate passedIssues Measures |
Builds ready [5dcdc42]
Page Load Metrics (1891 ± 122 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
kanthesha
deleted the
feat/preferences-controller-to-base-controller-v2
branch
October 14, 2024 17:51
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 14, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.7.0
Issue or pull request that will be included in release 12.7.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we want to bring PreferencesController up to date with our latest controller patterns by upgrading to BaseControllerV2.
Related issues
Fixes: #25917
Manual testing steps
Use case 1
Use case 2
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist