Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preferences controller to base controller v2 #27398

Merged
merged 64 commits into from
Oct 14, 2024
Merged

feat: preferences controller to base controller v2 #27398

merged 64 commits into from
Oct 14, 2024

Conversation

kanthesha
Copy link
Contributor

@kanthesha kanthesha commented Sep 25, 2024 •
edited
Loading

Description

In this PR, we want to bring PreferencesController up to date with our latest controller patterns by upgrading to BaseControllerV2.

Open in GitHub Codespaces

Related issues

Fixes: #25917

Manual testing steps

Use case 1

  1. Install the previous release
  2. Complete user onboarding
  3. Go to settings and change couple of user settings. For example language, currency and theme.
  4. Close and disable MM in the extension
  5. Checkout the version with these changes
  6. Build and login
  7. Make sure, the user preferences set earlier are still there

Use case 2

  1. Disable all the MM extensions
  2. Install the version with these changes
  3. When you click on MM, the default language should be English
  4. Complete user onboarding
  5. Go to settings and change couple of user settings. For example language, currency and theme.
  6. Close and disable and enable the MM in extension. which forces user to login MM in the extension
  7. Once you login again, make sure, the user preferences set earlier are still there

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [efda3a4]
Page Load Metrics (1908 ± 175 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61323321784337162
domContentLoaded156032301879363175
load156832351908365175
domInteractive14207454019
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 501 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [51e8886]
Page Load Metrics (1771 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15352108177712560
domContentLoaded15262022173511756
load15342108177112560
domInteractive16156482914
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 512 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@kanthesha kanthesha marked this pull request as ready for review September 26, 2024 12:13
@kanthesha kanthesha requested review from kumavis and a team as code owners September 26, 2024 12:13
@kanthesha kanthesha mentioned this pull request Sep 26, 2024
Closed
7 tasks
@metamaskbot
Copy link
Collaborator

Builds ready [9d9291f]
Page Load Metrics (1843 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34624031765396190
domContentLoaded15852301179820799
load164324221843229110
domInteractive17188594220
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 512 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [0eb3dc5]
Page Load Metrics (1832 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint165524711841216104
domContentLoaded16202332178617182
load16572395183218790
domInteractive2596482010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 10.64 KiB (0.26%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@kanthesha kanthesha added this pull request to the merge queue Oct 14, 2024
@kanthesha kanthesha removed this pull request from the merge queue due to a manual request Oct 14, 2024
@kanthesha
Merge branch 'develop' of github.com:MetaMask/metamask-extension into…
c7abe9b 
… feat/preferences-controller-to-base-controller-v2
@kanthesha
Merge branch 'feat/preferences-controller-to-base-controller-v2' of g…
0c94e58 
…ithub.com:MetaMask/metamask-extension into feat/preferences-controller-to-base-controller-v2
@kanthesha kanthesha added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 14, 2024
@kanthesha kanthesha added this pull request to the merge queue Oct 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [e0f925e]
Page Load Metrics (1883 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint155928021873283136
domContentLoaded155127951821282135
load155928031883288138
domInteractive25194593919
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 10.65 KiB (0.26%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kanthesha kanthesha added this pull request to the merge queue Oct 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5dcdc42]
Page Load Metrics (1891 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint165224801901256123
domContentLoaded160524111867254122
load161524291891254122
domInteractive26256755928
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 10.65 KiB (0.26%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit cedabc6 Oct 14, 2024
78 checks passed
@kanthesha kanthesha deleted the feat/preferences-controller-to-base-controller-v2 branch October 14, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 14, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt left review comments

@MajorLift MajorLift MajorLift left review comments

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@mikesposito mikesposito mikesposito left review comments

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

Assignees

@kanthesha kanthesha

Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate PreferencesController to BaseController v2
8 participants
@kanthesha @metamaskbot @DDDDDanica @Gudahtt @MajorLift @mikesposito @cryptodev-2s @gauthierpetetin