chore: add testing-library/dom dependency #27493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
github-actions
bot
added
the
team-confirmations
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@testing-library/dom@7.22.2, npm/dom-accessibility-api@0.5.0 |
|
cryptotavares
force-pushed
the
cryptotavares/add-testing-library-dom
branch
from
9d6509c
to
c119474
Compare
Builds ready [c119474]
Page Load Metrics (1886 ± 118 ms)
Bundle size diffs
|
cryptotavares
force-pushed
the
cryptotavares/add-testing-library-dom
branch
from
c119474
to
05364e2
Compare
Builds ready [05364e2]
Page Load Metrics (2064 ± 122 ms)
Bundle size diffs
|
Builds ready [27a0e22]
Page Load Metrics (1801 ± 60 ms)
Bundle size diffs
|
cryptotavares
force-pushed
the
cryptotavares/add-testing-library-dom
branch
from
27a0e22
to
f106df5
Compare
Builds ready [f106df5]
Page Load Metrics (2062 ± 163 ms)
Bundle size diffs
|
cryptotavares
force-pushed
the
cryptotavares/add-testing-library-dom
branch
from
7d20de8
to
407d5e5
Compare
cryptotavares
force-pushed
the
cryptotavares/add-testing-library-dom
branch
from
407d5e5
to
c9f69ba
Compare
Builds ready [2341200]
Page Load Metrics (1834 ± 74 ms)
Bundle size diffs
|
cryptotavares
force-pushed
the
cryptotavares/add-testing-library-dom
branch
from
2341200
to
fb81083
Compare
Builds ready [fb81083]
Page Load Metrics (2152 ± 73 ms)
Bundle size diffs
|
|
For some reason the updates to the lock file from running the dedupe command, make the tests fail if there are obsolete snapshots. That's the reason I removed all obsolete snapshots on this PR |
zone-live
approved these changes
Oct 18, 2024
pedronfigueiredo
approved these changes
Oct 18, 2024
OGPoyraz
approved these changes
Oct 18, 2024
metamaskbot
added
the
release-12.8.0
gauthierpetetin
added
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are adding testing-library/dom as direct dependency in order to start leveraging the testing library testing playground. (As a note, latest versions of
testing-library/reacthavetesting-library/domas a peer dep instead of a dependency. Though we are not updatingtesting-library/reactto the latest version as it requires React 18 and we are still in React 16).Using the
screenfrom thedomlibrary we can now usescreen.logTestingPlaygroundURL()(with or without a specific section passed into it) and when running the test it will log an url in the console for that specific component in the testing playground. We can use that to validate what is getting rendered and what is the suggested query to infer and write expectations on certain elements/text/values.Example of a logged url:
https://testing-playground.com/#markup=DwEwlgbgBAxgNgQwM5ILwCIC2mC0AjAewA9YCA7AMzACdcxKCdqCB3KbfYnHTBagc3o4ALgQAOOAEztchIt14ChhYaNzSOc7mIQhwZfkzD8AFsKkzO8nDr31DcAKYVzG2VxzgkYxAE8cFE4kmh6BjvLg1I4wwmDkTKyWWgFBOCzUCBLpmUkeAFYArkixFP4w5MKOZObeCDCO+I7CLI5VudblcATUIuHmIM4IBXDC7dzMBWQDIDhw-OhQxb5OGAQQjtSBrGkZYgBcUAhkviwmG44A3OxCZ8ZmB5IALGJEV2IESGCx5AdRiLHrC7oAB8oEgsEQKAwIWC7msXh8CH8YVhVm4KM8NGi3zICTYMO4hWKYFKOHK1Sq5nqFOoYxwCDgxlxX0cmCQKXCOGKfGEILB0HgyDQWDhdIRfg5qOSDKZOBZbLJlI2fLEEKF0NFHEqRFGWr63EIIH8mBmmEc4AKmDpnW6crIZ2oXxBAFFibxKiBYCYjvxHEhgAB6MSg8AQEPgwVQ9ALYQIPD0AZEDAABgWSxW6HFSIOKKBUBACFjIgIBBGYDEYnNGAWfDACE8fpgjrw5rwvgwsQr-lEpc7OAAjKn84X691jPQGSIvhnXbF3eavT6-YcolBToXrqZRt6K20SVBfAQClB+AQoMITBNTGuviZzyYwEhzxkyEg6jiAHRQAAqD6fj6gIlRgQKAxCicAYjiMgABooDIAhgJPAo+COSpHA-PlajINUoxhSwwHJfDyW4T4AC8GiQK0CR4PhBFxJwXAHMVH0Rfx6EZMgGjwLoYAAa2tUtbQI+JMAKD002EZZHGhZBeLlXhfQOApqDgAAKAByD8AzABS-W08kkADABHAo-U-JAIH4dSAEogVBAMsPs0MnMgFyw0DZz+Rw4U8OorNkSCOl+EyCxqIxbIsl2OkZX4ZlKgValKlpajMCEFgwBAC8cFTUFVUjHzNVwbVdSK-VOCNHhPWom0enoB0nUWSSM1OFkuR0eoDjAhoIrsgBNI91NXQQIHsRYCDNchHCgRw4CQKbK1oR9PnIc8z28KpPQvACEEwI9qigChmCtQ9lMOGBykmYQP0DYMPNcu73NDbyNSsUhKBoOgGDxOlFDo4sJDcNEaKUXEVDUUK4W0XR9EMR0twhoHbBh2ZnFcZjvAlFE6QxSJsSg76wtSCKdhyaigJJMoKkpNq6i4poWjaarBJ6YqGwoIYRjpCYpnNWZ5kaqTVnWTYuhYEn9kOY5TnOK5UtxW4tweZ5XlAj4vig34ZsLSBLj5J78peuR0dYyVsdSXHIPiZh8UhnBydJclKmqRUaWixlYrleL2QxblqF5cMBUhArXr8ljMcC6iYri1l2US5VcuekUQ9KnVLFZ8rjVNc0wEtASulq+0NidYEAGVKymUaYEyG63NrryDaTuQJMFrBaKEBjhAOIZRFlhB5HSzKTAOQdkwAUjs+ug8N4hjfD8I3dleVY6Vag9YjKfG5nlK2+ZMgOIaDamNDjGkTtfefrSjKspy4A8o33yU5K3odQNAgKpNNOytZqOXaSukkfsGfegDRAbSndtHBKK8862lZgMdmwwn7JDwHUXi-BuYzBqvgFBaC9ozAZElMg2t1hc1wbzIgcAFgFiLJUYkIAMCfFEv8fGoheJVBwBABkpkQT9hrg9AOAdE6ELNHBHajgAD6YjUooHsJhHQ2EG54SEeIsRwlsIcFUUReIXIwDkUqrPU+7FgH4B4vxJm+c7T1V5ALDMvAkByR0ggRSUBlJqU0tpXShlVGGRMmZKCH4LJWVsnyByciE4KMKs-UYSiJEcLgKZT+L8M56LMTA-UcCOb+2TEQZMAB2AAbP2R4H5ikAGZdB5IABy8IDJ5Gp906nuQabXIAA
Related issues
Fixes: None
Pre-merge author checklist
Pre-merge reviewer checklist