Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codefence Account Watcher for flask #27543

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

k-g-j
Copy link
Contributor

@k-g-j k-g-j commented Oct 1, 2024

Description

This PR puts the Account Watcher feature under the Flask codefence, restricting it to only be included in Flask builds.

Manual testing steps

  1. Build the extension in Flask mode
  2. Verify the account watcher feature is present
  3. Build the extension in non-Flask mode
  4. Verify the account watcher feature is not present

Screenshots/Recordings

The option to "Watch Ethereum Accounts (Beta)" should NOT be present on the Main build

Screen.Recording.2024-10-01.at.5.35.18.PM.mov

The option to "Watch Ethereum Accounts (Beta)" should BE PRESENT on the Flask build

Screen.Recording.2024-10-01.at.5.38.04.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@k-g-j
Copy link
Contributor Author

k-g-j commented Oct 1, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@k-g-j k-g-j added the flask label Oct 1, 2024
@k-g-j k-g-j marked this pull request as ready for review October 1, 2024 21:29
@k-g-j k-g-j requested review from a team as code owners October 1, 2024 21:29
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 1, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [5a31ef6]
Page Load Metrics (1743 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1539197917439545
domContentLoaded1532196817229244
load1540198017439546
domInteractive237036147
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -384 Bytes (-0.01%)
  • ui: -2.37 KiB (-0.03%)
  • common: -469.3 KiB (-5.81%)

Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [1f2c2ee]
Page Load Metrics (1699 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19019871633350168
domContentLoaded14781859167710651
load14861973169911656
domInteractive24186503617
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -384 Bytes (-0.01%)
  • ui: -2.37 KiB (-0.03%)
  • common: -469.3 KiB (-5.81%)

@k-g-j k-g-j added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit ab37660 Oct 2, 2024
76 of 77 checks passed
@k-g-j k-g-j deleted the feat/flask-codefence-account-watcher branch October 2, 2024 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 2, 2024
@k-g-j k-g-j added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flask INVALID-PR-TEMPLATE PR's body doesn't match template release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants