Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix changelog for v12.4.0 #27558

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore: Fix changelog for v12.4.0 #27558

merged 2 commits into from
Oct 8, 2024

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Oct 2, 2024

Description

Fix changelog for v12.4.0

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [a180f9c]
Page Load Metrics (1896 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24223031651608292
domContentLoaded15682288186717986
load15772304189618086
domInteractive1392412311

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (bc08781) to head (a180f9c).

Additional details and impacted files
@@               Coverage Diff                @@
##           Version-v12.4.0   #27558   +/-   ##
================================================
  Coverage            70.05%   70.05%           
================================================
  Files                 1422     1422           
  Lines                49677    49677           
  Branches             13887    13887           
================================================
  Hits                 34800    34800           
  Misses               14877    14877           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjetpoluru
Copy link
Contributor

@chloeYue, could you please add this in the changelog under the fixed section
Improved extension load time by using an interstitial page and deferred script tags. (#26555)

@chloeYue
Copy link
Contributor Author

chloeYue commented Oct 2, 2024

@chloeYue, could you please add this in the changelog under the fixed section Improved extension load time by using an interstitial page and deferred script tags. (#26555)

this one was for release 12.2.0, we should remove this one from google sheet and not add it here

@hjetpoluru
Copy link
Contributor

ok thanks @chloeYue, I have removed it from the excel too.

@danjm danjm merged commit dfbead6 into Version-v12.4.0 Oct 8, 2024
68 of 70 checks passed
@danjm danjm deleted the v12.4.0-changelog branch October 8, 2024 19:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants