Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide chainId prop for Asset List #27724

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Oct 9, 2024

Description

This PR sets shows the network badge specific to the asset, not the globally selected chain ID. Of course for now, that chainId is shimmed to be the current chainId until we have the Accounts API providing those assets in correct form

Open in GitHub Codespaces

** ToDo **

  • Ensure that the AssetPicker in Send and Swaps looks correct
  • Do the same for the Assets Detail page

Related issues

Fixes:

Manual testing steps

  1. Go to token list and check the network badge
  2. Go to asset picker and check the network badge
  3. Go to asset details and check the network badge

Screenshots/Recordings

Before

SCR-20241009-irdt SCR-20241009-irgl

After

Should be the same
Screenshot 2024-10-17 at 20 37 16

Screenshot 2024-10-17 at 20 37 47

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested review from a team as code owners October 9, 2024 14:20
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing changed the title Multichain: Use Asset ChainId for Asset List Multichain: Provide chainId prop for Asset List Oct 15, 2024
@darkwing darkwing added team-wallet-ux portfolio-view Used for PRs and issues related to Q4 2024 portfolio view labels Oct 16, 2024
@salimtb salimtb marked this pull request as draft October 16, 2024 14:17
@salimtb salimtb changed the title Multichain: Provide chainId prop for Asset List feat: Provide chainId prop for Asset List Oct 17, 2024
@salimtb salimtb marked this pull request as ready for review October 17, 2024 21:49
@salimtb salimtb requested review from a team as code owners October 17, 2024 21:49
@metamaskbot
Copy link
Collaborator

Builds ready [3a11cd8]
Page Load Metrics (1744 ± 171 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28730461606536258
domContentLoaded151925011682212102
load154332051744356171
domInteractive26112572311
backgroundConnect95585612058
firstReactRender43235894120
getState36014212962
initialActions01000
loadScripts11291641124912761
setupStore10338397234
uiStartup170852922034774371
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -68 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb self-assigned this Oct 23, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [97c4bab]
Page Load Metrics (1950 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint170326941958233112
domContentLoaded165326251902219105
load170626971950236113
domInteractive15215665124
backgroundConnect12113433215
firstReactRender4510285168
getState673312311
initialActions01000
loadScripts11812087141219593
setupStore117125189
uiStartup188228822150249120
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -68 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

gambinish
gambinish previously approved these changes Oct 23, 2024
NidhiKJha
NidhiKJha previously approved these changes Oct 24, 2024
@darkwing darkwing dismissed stale reviews from NidhiKJha and gambinish via 4e98d1a October 24, 2024 13:11
@metamaskbot
Copy link
Collaborator

Builds ready [4e98d1a]
Page Load Metrics (1975 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16822224197415172
domContentLoaded16272205193514469
load16822223197514871
domInteractive16103552311
backgroundConnect1388452914
firstReactRender522251054220
getState599272713
initialActions01000
loadScripts11741756144012560
setupStore1293462713
uiStartup186729252237224107
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 176 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

@Joj501 Joj501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants