-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide chainId prop for Asset List #27724
base: develop
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
54568ff
to
ceeb76b
Compare
ceeb76b
to
d8a07a3
Compare
562c769
to
b1e2daa
Compare
Builds ready [3a11cd8]
Page Load Metrics (1744 ± 171 ms)
Bundle size diffs
|
Builds ready [97c4bab]
Page Load Metrics (1950 ± 113 ms)
Bundle size diffs
|
Builds ready [4e98d1a]
Page Load Metrics (1975 ± 71 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🟢
Description
This PR sets shows the network badge specific to the asset, not the globally selected chain ID. Of course for now, that chainId is shimmed to be the current chainId until we have the Accounts API providing those assets in correct form
** ToDo **
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Should be the same
Pre-merge author checklist
Pre-merge reviewer checklist