perf (cherry-pick): add tags to UI startup trace (#27550) #27727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** Add the following tags to the `UI Startup` trace to help identify correlations in startup performance: - `wallet.account_count` - Total number of all accounts in wallet. - `wallet.nft_count` - Total number of all NFTs in the wallet, across all accounts and chains. - `wallet.notification_count` - Total number of notifications in the wallet. - `wallet.pending_approval` - Approval type of the first pending approval. e.g. `transaction`, `eth_signTypedData` - `wallet.token_count` - Total number of ERC-20 tokens in the wallet, across all chains and accounts. - `wallet.transaction_count` - Total number of transactions currently in the wallet, across all accounts, chains, and statuses. - `wallet.unlocked` - `true` or `false` based on if the wallet is currently locked and requires a password. - `wallet.ui_type` - Type of UI being loaded. e.g. `popup`, `notification`, `fullscreen` Tags with a `number` value are Sentry measurements to allow querying with greater than and less than logic. [](https://codespaces.new/MetaMask/metamask-extension/pull/27550?quickstart=1) ## **Related issues** Fixes: [#3379](MetaMask/MetaMask-planning#3379) [#3273](MetaMask/MetaMask-planning#3273) ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Mark Stacey <markjstacey@gmail.com>
matthewwalsh0
added
team-tiger
](https://codespaces.new/MetaMask/metamask-extension/pull/27550?quickstart=1){kind=link}
Builds ready [8121398]
Page Load Metrics (1963 ± 123 ms)
|
HowardBraham
approved these changes
Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick of #27550 for release 12.5.0.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist