Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf (cherry-pick): add tags to UI startup trace (#27550) #27727

Merged

Commits on Oct 9, 2024

  1. perf: add tags to UI startup trace (#27550)

    ## **Description**
    
    Add the following tags to the `UI Startup` trace to help identify
    correlations in startup performance:
    
    - `wallet.account_count`
      - Total number of all accounts in wallet.
    - `wallet.nft_count`
    - Total number of all NFTs in the wallet, across all accounts and
    chains.
    - `wallet.notification_count`
      - Total number of notifications in the wallet.
    - `wallet.pending_approval`
    - Approval type of the first pending approval. e.g. `transaction`,
    `eth_signTypedData`
    - `wallet.token_count`
    - Total number of ERC-20 tokens in the wallet, across all chains and
    accounts.
    - `wallet.transaction_count`
    - Total number of transactions currently in the wallet, across all
    accounts, chains, and statuses.
    - `wallet.unlocked`
    - `true` or `false` based on if the wallet is currently locked and
    requires a password.
    - `wallet.ui_type`
      - Type of UI being loaded. e.g. `popup`, `notification`, `fullscreen`
    
    Tags with a `number` value are Sentry measurements to allow querying
    with greater than and less than logic.
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27550?quickstart=1)
    
    ## **Related issues**
    
    Fixes:
    [#3379](MetaMask/MetaMask-planning#3379)
    [#3273](MetaMask/MetaMask-planning#3273)
    
    ## **Manual testing steps**
    
    ## **Screenshots/Recordings**
    
    ### **Before**
    
    ### **After**
    
    ## **Pre-merge author checklist**
    
    - [x] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    
    ---------
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    matthewwalsh0 and Gudahtt committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    50d3e02 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8121398 View commit details
    Browse the repository at this point in the history