Commits on Oct 10, 2024

1. fix: Limit amount of decimals on spending cap modal (#27672) …

   <!--
   Please submit this PR as a draft initially.
   Do not mark it as "Ready for review" until the template has been
   completely filled out, and PR status checks have passed at least once.
   -->
   
   ## **Description**
   
   <!--
   Write a short description of the changes included in this pull request,
   also include relevant motivation and context. Have in mind the following
   questions:
   1. What is the reason for the change?
   2. What is the improvement/solution?
   -->
   
   If the user tries to add more decimals to the spending cap than what the
   token supports, the spending cap cannot be submitted and a notice is
   displayed.
   
   [![Open in GitHub
   Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27672?quickstart=1)
   
   ## **Related issues**
   
   Fixes: #27618
   
   ## **Manual testing steps**
   
   1. Go to this page...
   2.
   3.
   
   ## **Screenshots/Recordings**
   
   <!-- If applicable, add screenshots and/or recordings to visualize the
   before and after of your change. -->
   
   ### **Before**
   
   <!-- [screenshots/recordings] -->
   
   ### **After**
   
   <!-- [screenshots/recordings] -->
   
   <img width="472" alt="Screenshot 2024-10-08 at 13 40 02"
   src="https://github.com/user-attachments/assets/1a54330a-0fb2-479f-b077-dd3d9c7485a9">
   
   
   
   ## **Pre-merge author checklist**
   
   - [ ] I've followed [MetaMask Contributor
   Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
   Extension Coding
   Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
   - [ ] I've completed the PR template to the best of my ability
   - [ ] I’ve included tests if applicable
   - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
   if applicable
   - [ ] I’ve applied the right labels on the PR (see [labeling
   guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
   Not required for external contributors.
   
   ## **Pre-merge reviewer checklist**
   
   - [ ] I've manually tested the PR (e.g. pull and build branch, run the
   app, test code being changed).
   - [ ] I confirm that this PR addresses all acceptance criteria described
   in the ticket it closes and includes the necessary testing evidence such
   as recordings and or screenshots.

   

   pedronfigueiredo committed Oct 10, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 9d748eb
   • Browse repository at this point

   Copy the full SHA

   9d748eb View commit details

   Browse the repository at this point in the history