Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: issue with nonce not updating correctly where there are multiple parallel transactions #27852

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 15, 2024

Description

Fix issue with nonce not updating when there are multiple transaction created in parallel and once transaction is submitted.

Related issues

Fixes: #27617

Manual testing steps

  1. Go to testdapp
  2. create 2 transactions and submit first one
  3. Nonce for second transaction should update

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Oct 15, 2024
@jpuri jpuri changed the base branch from Version-v12.5.0 to develop October 15, 2024 15:11
@jpuri jpuri changed the base branch from develop to Version-v12.5.0 October 15, 2024 17:35
@jpuri jpuri changed the title fix: issue with nonce not updating correctly where there are multiple parallel transactions cherry-pick: issue with nonce not updating correctly where there are multiple parallel transactions Oct 15, 2024
@jpuri jpuri marked this pull request as ready for review October 15, 2024 17:38
@jpuri jpuri requested a review from a team as a code owner October 15, 2024 17:38
@hjetpoluru hjetpoluru self-requested a review October 15, 2024 18:54
@hjetpoluru hjetpoluru merged commit aa7634f into Version-v12.5.0 Oct 15, 2024
69 of 72 checks passed
@hjetpoluru hjetpoluru deleted the 12.5.0_nonce_fix branch October 15, 2024 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Oct 15, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.5.0 on PR, as PR was cherry-picked in branch 12.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants