Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Automatically expand first insight #27872

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 15, 2024

Description

Automatically expands the first insight on the confirmation page, if any.

Open in GitHub Codespaces

Related issues

Fixes: #27869

Screenshots/Recordings

image

@FrederikBolding FrederikBolding added the team-snaps-platform Snaps Platform team label Oct 15, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner October 15, 2024 14:27
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 15, 2024
Copy link

sonarcloud bot commented Oct 15, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [dc76dec]
Page Load Metrics (1930 ± 110 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39025131836393189
domContentLoaded15632256186117082
load158025671930228110
domInteractive28212664220
backgroundConnect9356649445
firstReactRender494041188239
getState5175295024
initialActions01000
loadScripts11341803137614771
setupStore114636210249
uiStartup177941742280608292
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 45 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Oct 21, 2024
Merged via the queue into develop with commit 29e1c5b Oct 21, 2024
76 checks passed
@FrederikBolding FrederikBolding deleted the fb/auto-expand-first-insight branch October 21, 2024 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Oct 21, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.8.0 Issue or pull request that will be included in release 12.8.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First insight container should be expanded
5 participants