Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nonce value when there are multiple transactions in parallel #27874

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 15, 2024

Description

Fix issue with nonce not updating when there are multiple transaction created in parallel and once transaction is submitted.

Related issues

Fixes: #27617

Manual testing steps

  1. Go to testdapp
  2. create 2 transactions and submit first one
  3. Nonce for second transaction should update

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 15, 2024
@jpuri jpuri marked this pull request as ready for review October 15, 2024 15:37
@jpuri jpuri requested a review from a team as a code owner October 15, 2024 15:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge October 15, 2024 15:48
@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [921c551]
Page Load Metrics (1817 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16062106181515072
domContentLoaded15952094178114569
load16082106181715072
domInteractive2587482010
backgroundConnect7139413416
firstReactRender452981116230
getState47315189
initialActions01000
loadScripts11791625133812861
setupStore1298383015
uiStartup179225672070221106

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@jpuri jpuri enabled auto-merge October 15, 2024 17:24
Copy link

sonarcloud bot commented Oct 15, 2024

@jpuri jpuri added this pull request to the merge queue Oct 15, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8ad15e6]
Page Load Metrics (1869 ± 171 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30931821790477229
domContentLoaded16032509179520498
load161832911869356171
domInteractive16118462512
backgroundConnect117937316881
firstReactRender47216863818
getState4106202713
initialActions01000
loadScripts11561736133614369
setupStore1197423014
uiStartup179634782107402193
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 50 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham changed the title fix: nonce value when there are multiple transactions in parallal fix: nonce value when there are multiple transactions in parallel Oct 15, 2024
Merged via the queue into develop with commit cc47ff9 Oct 15, 2024
81 checks passed
@jpuri jpuri deleted the nonce_fix branch October 15, 2024 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 15, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Nonce - Nonce doesn't update while having 2 pending transactions, and after confirming the first one
6 participants