-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: removed feature flag for confirmations screen #27877
Conversation
23f1913
to
eadbdb6
Compare
Builds ready [7c2250d]
Page Load Metrics (1908 ± 83 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [894cf7a]
Page Load Metrics (1993 ± 139 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Thanks @NidhiKJha ! Looks good; i have tested this locally; when switching to Base i do see a warning at the top which does not appear in the screenshot just wanted to make sure its expected |
Did not have latest changes; tested locally again and i dnt see the warning anymore |
LGTM! thnx 🙏 |
Quality Gate passedIssues Measures |
Builds ready [15b16a0]
Page Load Metrics (2941 ± 164 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
15b16a0
to
a06d36c
Compare
Builds ready [a06d36c]
Page Load Metrics (1884 ± 98 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
a06d36c
to
fd377f5
Compare
Builds ready [fd377f5]
Page Load Metrics (1952 ± 140 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [6091121]
Page Load Metrics (1779 ± 57 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
element: 'Chip', | ||
key: 'network-chip', | ||
props: { | ||
label: pendingApproval.requestData.chainName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chip was removed because we don't want to show network chip or network picker anymore as per figma design .
], | ||
}, | ||
multichainFlag && { | ||
element: 'BannerAlert', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have callouts to show different alerts for confirmations. So, to show a banner for just one case wasn't working fine. Hence we decided to remove it. cc @mmragkandala
Builds ready [556ea30]
Page Load Metrics (1855 ± 98 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This PR is to remove the feature flag from confirmations page
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3517
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist