Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SENTRY_DSN_FAKE problem #27881

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix: SENTRY_DSN_FAKE problem #27881

merged 2 commits into from
Oct 15, 2024

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Oct 15, 2024

Description

Fixing this problem:
https://github.com/MetaMask/metamask-extension/pull/27548/files#r1801845403

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@HowardBraham HowardBraham added the team-tiger Tiger team (for tech debt reduction + performance improvements) label Oct 15, 2024
@HowardBraham HowardBraham self-assigned this Oct 15, 2024
@HowardBraham HowardBraham requested a review from a team as a code owner October 15, 2024 20:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-contributor-experience MetaMask Contributor Experience Group label Oct 15, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue on my local environment and sentry account.

Copy link

sonarcloud bot commented Oct 15, 2024

@HowardBraham HowardBraham added this pull request to the merge queue Oct 15, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [39088bb]
Page Load Metrics (2036 ± 130 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29629601798669321
domContentLoaded160227111999259124
load161227962036270130
domInteractive17160493316
backgroundConnect693412713
firstReactRender542561194823
getState4106202612
initialActions00000
loadScripts110821221488239115
setupStore13152343416
uiStartup182434592307358172
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 15, 2024
Merged via the queue into develop with commit 42e5eab Oct 15, 2024
79 checks passed
@HowardBraham HowardBraham deleted the fix-sentry-dsn-fake branch October 15, 2024 22:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 15, 2024
@HowardBraham HowardBraham removed the team-contributor-experience MetaMask Contributor Experience Group label Oct 18, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants