fix: flaky test Snap Account Signatures and Disconnects can connect to the Test Dapp, then #signTypedDataV3, disconnect then connect, then #signTypedDataV4 (async flow approve)
#27887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
seaona
changed the title
Snap Account Signatures and Disconnects can connect to the Test Dapp, then #signTypedDataV3, disconnect then connect, then #signTypedDataV4 (async flow approve)
seaona
commented
Oct 16, 2024
| text: 'Edit', | ||
| tag: 'button', | ||
| }); | ||
| await edit[1].click(); |
There was a problem hiding this comment.
since there are 2 elements with the exact same test id and text, we use findClickableElements and then click. Since findClickableElements already makes sure that the element is clickable, we won't run into any race condition where we try to click an element that is not clickable
seaona
commented
Oct 16, 2024
| await driver.waitForSelector({ | ||
| css: '[id="chainId"]', | ||
| text: '0x539', | ||
| }); |
There was a problem hiding this comment.
we make sure that we continue to be on localhost in the test dapp, after connecting. There's no reason to change networks.
This will make that the test fails deterministically in the future, if there's ever an unintended network switch
Builds ready [80d2704]
Page Load Metrics (2148 ± 171 ms)
Bundle size diffs
|
|
Builds ready [4c888ce]
Page Load Metrics (2066 ± 139 ms)
Bundle size diffs
|
chloeYue
approved these changes
Oct 16, 2024
HowardBraham
approved these changes
Oct 16, 2024
DDDDDanica
approved these changes
Oct 16, 2024
metamaskbot
added
the
release-12.7.0
gauthierpetetin
added
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After connecting to the test dapp we are automatically switched to Mainnet (this is a recent change, didn't happen before). Then there is a race condition where the network the dapp sees is different from the wallet one, causing a miss-match and making the signature fail never opening the dialog.
This seems an issue on the wallet side, as we should preserve the selected network after connecting, as we used to do before.
I've opened an issue for that here.
This just fixes the issue on the e2e side, but it needs to be fixed on the wallet side and remove the extra step again once the issue is fixed.
Related issues
Fixes: #27892
Manual testing steps
Screenshots/Recordings
See how you are automatically switched to mainnet
switched-to-mainnet.mp4
Pre-merge author checklist
Pre-merge reviewer checklist