-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky test Permissions sets permissions and connect to Dapp
#27888
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Permissions sets permissions and connect to Dapp
); | ||
await driver.clickElement({ | ||
await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog); | ||
await driver.clickElementAndWaitForWindowToClose({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes race condition
assert.equal( | ||
(await getAccountsResult.getText()).toLowerCase(), | ||
publicAddress.toLowerCase(), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, we find the element by its text above
const extension = windowHandles[0]; | ||
await driver.switchToWindowWithTitle( | ||
WINDOW_TITLES.Dialog, | ||
windowHandles, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this extra logic is not needed. switchToWindowWithTitle already waits for the dialog and switches when its ready
Quality Gate passedIssues Measures |
Builds ready [b7ac47b]
Page Load Metrics (2322 ± 125 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for the fix !
Description
We proceed switching to the Extension full view without waiting until the dialog is closed.
Related issues
Fixes: #27890
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist