fix: flaky test ERC721 NFTs testdapp interaction should prompt users to add their NFTs to their wallet (all at once)

[seaona]

Description

The problem is that we are looking for the Deposit transaction by its text in the activity tab, but this element updates its state, from pendingto confirm, meaning that it can become stale when we do the assertion after (see video).

await driver.waitForSelector({
          css: '[data-testid="activity-list-item-action"]',
          text: 'Deposit',
});
assert.equal(await transactionItem.isDisplayed(), true);

To mitigate this problem, we wait until the transaction is confirmed, and then look for the Deposit tx.
This not only fixes the race condition, but it also ensures that the tx is successful.

Related issues

Fixes: #26759

Manual testing steps

1. Check ci

Screenshots/Recordings

stale-element-activity.mp4

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[seaona]

this causes the race condition, as we are asserting an element that it doesn't exist anymore as it has been updated

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [5bfd3a8]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2102 ± 186 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1676	3210	2102	393	189
		domContentLoaded	1638	3135	2062	384	185
		load	1678	3152	2102	387	186
		domInteractive	31	201	62	36	17
		backgroundConnect	13	82	40	24	11
		firstReactRender	49	197	105	32	15
		getState	6	68	22	23	11
		initialActions	0	0	0	0	0
		loadScripts	1212	2697	1568	358	172
		setupStore	12	88	33	25	12
		uiStartup	1885	3410	2334	401	192

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[chloeYue]

LGTM !