test: update notification date tests to be timezone agnostic #27925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| @@ -16,3 +16,4 @@ process.env.PUSH_NOTIFICATIONS_SERVICE_URL = | |||
| process.env.PORTFOLIO_URL = 'https://portfolio.test'; | |||
| process.env.METAMASK_VERSION = 'MOCK_VERSION'; | |||
| process.env.ENABLE_CONFIRMATION_REDESIGN = 'true'; | |||
| process.env.TZ = 'UTC'; | |||
There was a problem hiding this comment.
Unsure if this actually has an impact in tests. Can I get other devs to test with/without this environment var?
There was a problem hiding this comment.
I will keep this in the test environment for now. It does not impact any other tests.
Leaving a comment here for future devs: This can be taken out if necessary 😄
Builds ready [f52f2a8]
Page Load Metrics (1855 ± 65 ms)
Bundle size diffs
|
…-timezone-agnostic
Builds ready [2061144]
Page Load Metrics (1982 ± 120 ms)
Bundle size diffs
|
gambinish
approved these changes
Oct 21, 2024
@gambinish I do not know of other developers in a different timezone, which makes this hard to test. I did some searching and the main culprit was the This is safe to merge, and we can keep an eye out if other devs or QA face this issue when running tests locally 😄 |
…-timezone-agnostic
| @@ -9,7 +9,7 @@ import { | |||
| describe('formatMenuItemDate', () => { | |||
| beforeAll(() => { | |||
| jest.useFakeTimers(); | |||
| jest.setSystemTime(new Date('2024-06-07T09:40:00Z')); | |||
| jest.setSystemTime(new Date(Date.UTC(2024, 5, 7, 9, 40, 0))); // 2024-06-07T09:40:00Z | |||
There was a problem hiding this comment.
This is the main culprit. We were setting the system time to a TZ specific date.
We have now changed this to a UTC (timezone agnostic) date. Hopefully this resolves issues that devs may face when running this test locally.
mathieuartu
approved these changes
Oct 22, 2024
Builds ready [6c9990d]
Page Load Metrics (1798 ± 92 ms)
Bundle size diffs
|
…-timezone-agnostic
Builds ready [2318281]
Page Load Metrics (1986 ± 104 ms)
Bundle size diffs
|
Prithpal-Sooriya
deleted the
test/update-notification-date-tests-to-be-timezone-agnostic
branch
metamaskbot
added
the
release-12.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A rare edge-case where unit tests locally (when in a different timezone) failed.
This updates the tests to use UTC dates and uses the UTC timezone.
NOTE - that these tests pass in CI and need to be tested locally by devs in different timezones.
Related issues
Fixes:
Manual testing steps
N/A - this has no impact on the extension, just tests.
You can try running this unit test locally to see if it passes.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist