-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge master into v12.5.0 (following v12.4.2) #27938
Merged
Merged
Commits on Oct 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 516af04 - Browse repository at this point
Copy the full SHA 516af04View commit details
Commits on Oct 16, 2024
-
fix: Correct conditions for triggering name lookup during send (#27880)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> Take changes from 5e08c06 ## **Description** Hotfixes a problem preventing certain name resolution Snaps from being triggered due to faulty `IS_FLASK` conditions in `12.4.1`. These conditions were removed in #26242. This PR picks these changes from the previously mentioned PR, without touching the ENS integration. The problem in question occurs when trying to trigger name resolution for a given input. `lookupDomainName` is never called on stable unless the input looks similar to an ENS name. This prevents resolution of inputs that don't use TLDs for instance. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27880?quickstart=1) ## **Manual testing steps** 1. Use a build of stable 2. Install https://snaps.metamask.io/snap/npm/social-names-snap/ 3. See that you can resolve a Farcaster name using that Snap, e.g. `fc:frederik` 4. Check that you can also type a valid ENS name 5. Check that you can also type a valid address --------- Co-authored-by: Hassan Malik <hbmalik88@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e4672a8 - Browse repository at this point
Copy the full SHA e4672a8View commit details -
chore: Update RC hotfix changelog (#27900)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Updates the hotfix RC changelog to mention the PR that was picked into the RC.
Configuration menu - View commit details
-
Copy full SHA for 9221f8e - Browse repository at this point
Copy the full SHA 9221f8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36fe5a8 - Browse repository at this point
Copy the full SHA 36fe5a8View commit details -
Merge pull request #27879 from MetaMask/Version-v12.4.2
Version v12.4.2 RC
Configuration menu - View commit details
-
Copy full SHA for 626289d - Browse repository at this point
Copy the full SHA 626289dView commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 43a66d4 - Browse repository at this point
Copy the full SHA 43a66d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ec1ce9 - Browse repository at this point
Copy the full SHA 6ec1ce9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f77f8f - Browse repository at this point
Copy the full SHA 9f77f8fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.