Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit flaky test AddContact component › should disable submit button when input is not a valid address #27941

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Oct 17, 2024

Description

The unit test for Add Account is flaky as sometimes the state[name].stage var is undefined so it breaks at this point:

Screenshot from 2024-10-18 09-22-26

The fix is to add this variable in the test setup, so it's always defined.

Open in GitHub Codespaces

Related issues

Fixes: #27624

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona self-assigned this Oct 17, 2024
@seaona seaona changed the title fix: unit flaky fix: unit flaky test AddContact component › should disable submit button when input is not a valid address Oct 17, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [f762a80]
Page Load Metrics (2190 ± 167 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23631042086548263
domContentLoaded170030562140334160
load171231422190348167
domInteractive17123552914
backgroundConnect9167504421
firstReactRender551981113316
getState5228385426
initialActions01000
loadScripts123522601578263126
setupStore12123473215
uiStartup193238852497477229
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona marked this pull request as ready for review October 18, 2024 07:19
@seaona seaona requested a review from a team as a code owner October 18, 2024 07:19
@metamaskbot
Copy link
Collaborator

Builds ready [7012156]
Page Load Metrics (1956 ± 64 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17692253196113766
domContentLoaded17452151191911756
load17732250195613364
domInteractive168251199
backgroundConnect1298412411
firstReactRender492951015225
getState593212411
initialActions01000
loadScripts12781626142610952
setupStore1399332512
uiStartup196029772196223107
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona added flaky tests area-qa Relating to QA work (Quality Assurance) labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests team-extension-platform
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

Flaky unit test "AddContact component › should disable submit button when input is not a valid address"
2 participants