-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new phishing warning UI with metrics #27942
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/phishing-warning@4.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HUGE win!!
Builds ready [3ccbd18]
Page Load Metrics (2006 ± 67 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: mar <72634565+mindofmar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this 🔥
…aMask/metamask-extension into feat/new-phishing-warning-ui
…aMask/metamask-extension into feat/new-phishing-warning-ui
Builds ready [473e201]
Page Load Metrics (2349 ± 332 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…aMask/metamask-extension into feat/new-phishing-warning-ui
Builds ready [d82a361]
Page Load Metrics (1956 ± 152 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [ee94373]
Page Load Metrics (1776 ± 126 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [dbde006]
Page Load Metrics (2169 ± 92 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR introduces the new phishing-warning-page UI in
v4.1.0
along with metrics to track when users click onBack to safety
which will lead them to the portfolio as well as when they click onproceed anyways
to better track False positivesSome notable improvements in the new UI:
proceed anyways
Related issues
Fixes:
Manual testing steps
eth-phishing-detect
such asweb3-lido.lol
and you will see the new phishing page UI!Back to safety
which will take you to the portfolio or you can click on proceed anyway which will take you to the scam website and allowlist it.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist