-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Disable account syncing in prod #27943
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -31,6 +31,8 @@ import { | |||||
providerErrors, | ||||||
} from '@metamask/rpc-errors'; | ||||||
|
||||||
import { isProduction } from '../../shared/modules/environment'; | ||||||
|
||||||
import { Mutex } from 'await-semaphore'; | ||||||
import log from 'loglevel'; | ||||||
import { | ||||||
|
@@ -1561,7 +1563,7 @@ export default class MetamaskController extends EventEmitter { | |||||
}, | ||||||
}, | ||||||
env: { | ||||||
isAccountSyncingEnabled: isManifestV3, | ||||||
isAccountSyncingEnabled: !isProduction() && isManifestV3,, | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm. This It only checks that this is not "development" or "testing":
But there are many other environments:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will be effective in disabling the check in production. But it will also disable it in any non-test builds produced on CircleCI, including release candidate builds, which would be confusing during release QA. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thoughts on setting this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Isn't that what we want, so that when v12.5.0 is tested, the feature is disabled? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fair enough, yes we would want those to be as production-like as possible. But our QA team uses a lot of different build types interchangeably, including development builds, so it would still be confusing. What was the reason for leaving it enabled for development and e2e testing? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I was just thinking not to inhibit the ongoing QA work. It can be more efficient to work with development builds while writing tests or doing exploratory testing.
danjm marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
}, | ||||||
messenger: this.controllerMessenger.getRestricted({ | ||||||
name: 'UserStorageController', | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be re-ordered, causing a lint error