Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint-lockfile flaky job by changing resources from medium to medium-plus #27950

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Oct 18, 2024

Description

The lint-lockfile job is flaky. It seems it's under-resourced peaking max cpu and ram values, as @Gudahtt pointed out:

Screenshot from 2024-10-18 09-14-33

Open in GitHub Codespaces

Related issues

Fixes: #27806

Manual testing steps

  1. Check lint-lockfile job

Screenshots/Recordings

Increasing resources from medium to medium-plus
https://circleci.com/pricing/price-list/

Screenshot from 2024-10-18 09-39-13

Resource usage after the change:

Screenshot from 2024-10-18 09-33-41

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested review from kumavis and a team as code owners October 18, 2024 07:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [38e841d]
Page Load Metrics (1760 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15342318176518287
domContentLoaded15262192172615876
load15352332176018187
domInteractive1897402210
backgroundConnect7136303216
firstReactRender45127822612
getState45918188
initialActions01000
loadScripts10831615126513867
setupStore1096342713
uiStartup168326631969215103
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review October 18, 2024 12:36
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona seaona added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@seaona seaona added this pull request to the merge queue Oct 18, 2024
Merged via the queue into develop with commit c44fb0b Oct 18, 2024
94 checks passed
@seaona seaona deleted the lockfile-medium-plus branch October 18, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Oct 18, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.8.0 Issue or pull request that will be included in release 12.8.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CI flaky tests release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: yarn check resolutions CI job is flaky
5 participants