Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): @keystonehq/metamask-airgapped-keyring@^0.13.1->^0.14.1 #27952

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 18, 2024

Description

Bump @keystonehq/metamask-airgapped-kayring, removing dependency on legacy @metamask/obs-store.

Open in GitHub Codespaces

Related issues

Manual testing steps

  • Test basic HW wallet flow with Keystone wallet

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@keystonehq/metamask-airgapped-keyring@0.13.1, npm/@metamask/obs-store@7.0.0, npm/@metamask/safe-event-emitter@2.0.0

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security team-hardware-wallets labels Oct 18, 2024
@legobeat legobeat marked this pull request as ready for review October 18, 2024 12:34
@legobeat legobeat requested review from a team as code owners October 18, 2024 12:34
@legobeat legobeat force-pushed the deps-keystone-keyring branch 3 times, most recently from 9867ba3 to c91dadf Compare October 21, 2024 18:55
HowardBraham
HowardBraham previously approved these changes Oct 22, 2024
@legobeat legobeat requested a review from a team October 22, 2024 21:56
@legobeat legobeat force-pushed the deps-keystone-keyring branch 2 times, most recently from 34c6ecd to 19aab1e Compare October 23, 2024 09:43
@legobeat legobeat added this pull request to the merge queue Oct 23, 2024
Merged via the queue into MetaMask:develop with commit 5668333 Oct 23, 2024
76 checks passed
@legobeat legobeat deleted the deps-keystone-keyring branch October 23, 2024 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants