Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce gas limit fallback from 95% to 35% of the block gas limit on failed gas limit estimations #27954

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Oct 18, 2024

Description

This PR applies the latest transaction-controller version that reduces gas limit fallback.

Open in GitHub Codespaces

Related issues

Fixes: MetaMask/core#4739

Manual testing steps

NA

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner October 18, 2024 11:09
@OGPoyraz OGPoyraz added the team-confirmations Push issues to confirmations team label Oct 18, 2024
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
jpuri
jpuri previously approved these changes Oct 18, 2024
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
@OGPoyraz OGPoyraz dismissed stale reviews from pedronfigueiredo and jpuri via 918b5ed October 21, 2024 13:29
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
…o-35-of-the-block-gas-limit-to-improve-how-we-handle-failed-gas-limit-estimations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
3 participants