Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app/pages): replaces all old checkbox imports; #27960

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ATH42
Copy link

@ATH42 ATH42 commented Oct 18, 2024

Description

This PR replaces all old imports of the checkbox component.
Open in GitHub Codespaces

Related issues

Closes: #20163

Manual testing steps

These changes, only impact imports

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

resolves MetaMask#20163

Note!!: i had to rename the Checkbox import in welcome.js, i can rename
the used component and drop the named import if needed
@ATH42 ATH42 requested review from a team as code owners October 18, 2024 13:57
Copy link
Contributor

github-actions bot commented Oct 18, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 18, 2024
@ATH42
Copy link
Author

ATH42 commented Oct 18, 2024

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated CheckBox component with Checkbox from the component-library
2 participants