Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app/pages): replaces all old checkbox imports; #27960

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
+13 −13
Open

refactor(app/pages): replaces all old checkbox imports; #27960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5147069
refactor(app/pages): replaces all old checkbox imports;
ATH42 Oct 18, 2024
d3c4936
trigger build
ATH42 Oct 18, 2024
44e7986
refactor(welcome): rename import
ATH42 Oct 18, 2024
5186215
rename test id;
ATH42 Oct 18, 2024
4becd89
rename locator prop for test;
ATH42 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ui/components/app/alerts/unconnected-account-alert/unconnected-account-alert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,10 @@ import {
import { isExtensionUrl, getURLHost } from '../../../../helpers/utils/util';
import Popover from '../../../ui/popover';
import Button from '../../../ui/button';
import Checkbox from '../../../ui/check-box';
import Tooltip from '../../../ui/tooltip';
import ConnectedAccountsList from '../../connected-accounts-list';
import { useI18nContext } from '../../../../hooks/useI18nContext';
import { Icon, IconName, Text } from '../../../component-library';
import { Icon, IconName, Text, Checkbox } from '../../../component-library';

const { ERROR, LOADING } = ALERT_STATE;

Expand Down
3 changes: 1 addition & 2 deletions ui/components/app/home-notification/home-notification.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ import React, { useState } from 'react';
import classnames from 'classnames';
import PropTypes from 'prop-types';
import Button from '../../ui/button';
import Checkbox from '../../ui/check-box';
import Tooltip from '../../ui/tooltip';
import { Icon, IconName } from '../../component-library';
import { Icon, IconName, Checkbox } from '../../component-library';
import { IconColor } from '../../../helpers/constants/design-system';

const HomeNotification = ({
Expand Down
7 changes: 5 additions & 2 deletions ui/pages/confirmations/components/signature-request-siwe/signature-request-siwe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ import { useHistory } from 'react-router-dom';
import log from 'loglevel';
import { isValidSIWEOrigin } from '@metamask/controller-utils';
import { providerErrors, serializeError } from '@metamask/rpc-errors';
import { BannerAlert, Text } from '../../../../components/component-library';
import {
BannerAlert,
Text,
Checkbox,
} from '../../../../components/component-library';
import Popover from '../../../../components/ui/popover';
import Checkbox from '../../../../components/ui/check-box';
import Button from '../../../../components/ui/button';
import { I18nContext } from '../../../../contexts/i18n';
import { PageContainerFooter } from '../../../../components/ui/page-container';
Expand Down
2 changes: 1 addition & 1 deletion ui/pages/create-account/connect-hardware/account-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React, { Component } from 'react';
import { getAccountLink } from '@metamask/etherscan-link';

import Button from '../../../components/ui/button';
import Checkbox from '../../../components/ui/check-box';
import { Checkbox } from '../../../components/component-library';
import Dropdown from '../../../components/ui/dropdown';

import { getURLHostName } from '../../../helpers/utils/util';
Expand Down
4 changes: 2 additions & 2 deletions ui/pages/onboarding-flow/secure-your-wallet/skip-srp-backup-popover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
Icon,
IconName,
IconSize,
Checkbox,
} from '../../../components/component-library';
import {
AlignItems,
Expand All @@ -20,7 +21,6 @@ import {
TextVariant,
} from '../../../helpers/constants/design-system';
import { setSeedPhraseBackedUp } from '../../../store/actions';
import Checkbox from '../../../components/ui/check-box';
import { ONBOARDING_COMPLETION_ROUTE } from '../../../helpers/constants/routes';
import {
MetaMetricsEventCategory,
Expand Down Expand Up @@ -97,7 +97,7 @@ export default function SkipSRPBackup({ handleClose }) {
className="skip-srp-backup-popover__checkbox"
onClick={() => setChecked(!checked)}
checked={checked}
dataTestId="skip-srp-backup-popover-checkbox"
data-testid="skip-srp-backup-popover-checkbox"
/>
<Text className="skip-srp-backup-popover__details">
{t('skipAccountSecurityDetails')}
Expand Down
7 changes: 3 additions & 4 deletions ui/pages/onboarding-flow/welcome/welcome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import { Carousel } from 'react-responsive-carousel';
///: END:ONLY_INCLUDE_IF
import Mascot from '../../../components/ui/mascot';
import Button from '../../../components/ui/button';
import { Text } from '../../../components/component-library';
import CheckBox from '../../../components/ui/check-box';
import { Text, Checkbox } from '../../../components/component-library';
import Box from '../../../components/ui/box';
import {
TextVariant,
Expand Down Expand Up @@ -238,10 +237,10 @@ export default function OnboardingWelcome() {
alignItems={AlignItems.center}
className="onboarding__terms-of-use"
>
<CheckBox
<Checkbox
id="onboarding__terms-checkbox"
className="onboarding__terms-checkbox"
dataTestId="onboarding-terms-checkbox"
data-testid="onboarding-terms-checkbox"
checked={termsChecked}
onClick={toggleTermsCheck}
/>
Expand Down