Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove delays from onboarding tests #27961

Merged
merged 2 commits into from
Oct 18, 2024
Merged

test: Remove delays from onboarding tests #27961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9b3601
test: Remove delays from onboarding tests
darkwing Oct 18, 2024
7e6ca71
Wait for animation stop
darkwing Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions test/e2e/tests/onboarding/onboarding.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ const {
onboardingCompleteWalletCreation,
regularDelayMs,
unlockWallet,
tinyDelayMs,
largeDelayMs,
} = require('../../helpers');
const FixtureBuilder = require('../../fixture-builder');
const {
Expand Down Expand Up @@ -287,7 +285,6 @@ describe('MetaMask onboarding @no-mmi', function () {
await driver.clickElement({
text: 'General',
});
await driver.delay(largeDelayMs);
await driver.clickElement({ text: 'Add a network' });

await driver.waitForSelector(
Expand All @@ -311,9 +308,7 @@ describe('MetaMask onboarding @no-mmi', function () {
const rpcUrlInputDropDown = await driver.waitForSelector(
'[data-testid="test-add-rpc-drop-down"]',
);
await driver.delay(tinyDelayMs);
await rpcUrlInputDropDown.click();
await driver.delay(tinyDelayMs);
await driver.clickElement({
text: 'Add RPC URL',
tag: 'button',
Expand Down Expand Up @@ -371,7 +366,6 @@ describe('MetaMask onboarding @no-mmi', function () {
await driver.clickElement(
`[data-rbd-draggable-id="${toHex(chainId)}"]`,
);
await driver.delay(largeDelayMs);
// Check localhost 8546 is selected and its balance value is correct
await driver.findElement({
css: '[data-testid="network-display"]',
Expand Down Expand Up @@ -530,8 +524,6 @@ describe('MetaMask onboarding @no-mmi', function () {
// pin extension walkthrough screen
await driver.clickElement('[data-testid="pin-extension-next"]');

await driver.delay(regularDelayMs);

for (let i = 0; i < mockedEndpoints.length; i += 1) {
const mockedEndpoint = await mockedEndpoints[i];
const isPending = await mockedEndpoint.isPending();
Expand Down
21 changes: 10 additions & 11 deletions test/e2e/tests/privacy/basic-functionality.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ const {
withFixtures,
importSRPOnboardingFlow,
WALLET_PASSWORD,
tinyDelayMs,
regularDelayMs,
largeDelayMs,
defaultGanacheOptions,
} = require('../../helpers');
const { METAMASK_STALELIST_URL } = require('../phishing-controller/helpers');
Expand Down Expand Up @@ -65,18 +62,14 @@ describe('MetaMask onboarding @no-mmi', function () {
});
await driver.clickElement('[data-testid="category-item-General"]');

await driver.delay(regularDelayMs);

await driver.clickElement(
'[data-testid="basic-functionality-toggle"] .toggle-button',
);

await driver.clickElement('[id="basic-configuration-checkbox"]');
await driver.clickElement({ text: 'Turn off', tag: 'button' });
await driver.clickElement('[data-testid="category-back-button"]');
await driver.delay(regularDelayMs);
await driver.clickElement('[data-testid="category-item-Assets"]');
await driver.delay(regularDelayMs);
await driver.clickElement(
'[data-testid="currency-rate-check-toggle"] .toggle-button',
);
Expand Down Expand Up @@ -114,7 +107,6 @@ describe('MetaMask onboarding @no-mmi', function () {
await driver.clickElement('[data-testid="network-display"]');

await driver.clickElement({ text: 'Ethereum Mainnet', tag: 'p' });
await driver.delay(tinyDelayMs);

// Wait until network is fully switched and refresh tokens before asserting to mitigate flakiness
await driver.assertElementNotPresent('.loading-overlay');
Expand Down Expand Up @@ -154,13 +146,20 @@ describe('MetaMask onboarding @no-mmi', function () {
tag: 'button',
});
await driver.clickElement('[data-testid="category-item-General"]');
await driver.delay(largeDelayMs);
// Wait until the onboarding carousel has stopped moving
// otherwise the click has no effect.
await driver.waitForElementToStopMoving(
'[data-testid="category-back-button"]',
);
await driver.clickElement('[data-testid="category-back-button"]');
await driver.delay(largeDelayMs);
// Wait until the onboarding carousel has stopped moving
// otherwise the click has no effect.
await driver.waitForElementToStopMoving(
'[data-testid="privacy-settings-back-button"]',
);
await driver.clickElement(
'[data-testid="privacy-settings-back-button"]',
);
await driver.delay(largeDelayMs);
await driver.clickElement({ text: 'Done', tag: 'button' });
await driver.clickElement('[data-testid="pin-extension-next"]');
await driver.clickElement({ text: 'Done', tag: 'button' });
Expand Down