-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [cherry-pick][12.5.0] bump message signing snap #27962
Closed
matteoscurati
wants to merge
3
commits into
Version-v12.5.0
from
cherry-pick-v12.5.0-02f7ec4479ad06d1dc3618172fdc64d04f04ca85
Closed
fix: [cherry-pick][12.5.0] bump message signing snap #27962
matteoscurati
wants to merge
3
commits into
Version-v12.5.0
from
cherry-pick-v12.5.0-02f7ec4479ad06d1dc3618172fdc64d04f04ca85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions (#27936) Bumps `@metamask/message-signing-snap` to `0.4.0` to allow portfolio to support automatic connections. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27306?quickstart=1) Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1136 This does not effect anything within the wallet. N/A N/A - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/message-signing-snap@0.3.3, npm/@metamask/rpc-errors@6.3.1, npm/@metamask/selected-network-controller@18.0.1, npm/zod@3.22.4 |
matteoscurati
changed the title
fix: bump message signing snap to support portfolio automatic connect…
fix: [cherry-pick][12.5.0] bump message signing snap
Oct 18, 2024
Builds ready [4adfd8d]
Page Load Metrics (1862 ± 75 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps
@metamask/message-signing-snap
to0.4.0
to allow portfolio to support automatic connections.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1136
Manual testing steps
This does not effect anything within the wallet.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist