Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick][12.5.0] bump message signing snap #27962

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Oct 18, 2024

Description

Bumps @metamask/message-signing-snap to 0.4.0 to allow portfolio to support automatic connections.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1136

Manual testing steps

This does not effect anything within the wallet.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ions (#27936)

Bumps `@metamask/message-signing-snap` to `0.4.0` to allow portfolio to
support automatic connections.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27306?quickstart=1)

Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1136

This does not effect anything within the wallet.

N/A

N/A

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@matteoscurati matteoscurati added the team-notifications Notifications team label Oct 18, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 18, 2024

@matteoscurati matteoscurati changed the title fix: bump message signing snap to support portfolio automatic connect… fix: [cherry-pick][12.5.0] bump message signing snap Oct 18, 2024
@matteoscurati matteoscurati marked this pull request as ready for review October 18, 2024 14:24
@matteoscurati matteoscurati requested review from a team as code owners October 18, 2024 14:24
@metamaskbot
Copy link
Collaborator

Builds ready [4adfd8d]
Page Load Metrics (1862 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24421721793380182
domContentLoaded15832111183814469
load15862169186215775
domInteractive17227474622

@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants