Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: btc send feature #27963

Closed
wants to merge 38 commits into from
Closed

feat: btc send feature #27963

wants to merge 38 commits into from

Conversation

montelaidev
Copy link
Contributor

Description

This PR enables the send feature for @metamask/bitcoin-wallet-snap

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/564

Manual testing steps

  1. Create a btc account
  2. Switch to the btc account
  3. Click send

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev self-assigned this Oct 18, 2024
@montelaidev montelaidev requested a review from a team as a code owner October 18, 2024 14:40
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/bitcoin-wallet-snap@0.8.1 network 0 1.63 MB metamaskbot

🚮 Removed packages: npm/@metamask/bitcoin-wallet-snap@0.7.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/@metamask/bitcoin-wallet-snap@0.8.1 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/bitcoin-wallet-snap@0.8.1

@montelaidev montelaidev mentioned this pull request Oct 18, 2024
7 tasks
///: BEGIN:ONLY_INCLUDE_IF(build-flask)
case BtcAccountType.P2wpkh: {
await sendMultichainTransaction(
BITCOIN_WALLET_SNAP_ID,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be replaced by account.metadata.snap.id and support any Bitcoin Snap, but it doesn't need to be handled now in this PR.

@montelaidev
Copy link
Contributor Author

Closed in favor of #27964

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4aeb917]
Page Load Metrics (1998 ± 117 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35826141912425204
domContentLoaded168124811956212102
load169226471998244117
domInteractive21256614924
backgroundConnect10172434723
firstReactRender512171094120
getState599322914
initialActions01000
loadScripts11931903145918086
setupStore11137313215
uiStartup188134882283405195
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 13 Bytes (0.00%)
  • common: 387 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants