-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: btc send feature #27963
feat: btc send feature #27963
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/bitcoin-wallet-snap@0.7.0 |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
///: BEGIN:ONLY_INCLUDE_IF(build-flask) | ||
case BtcAccountType.P2wpkh: { | ||
await sendMultichainTransaction( | ||
BITCOIN_WALLET_SNAP_ID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be replaced by account.metadata.snap.id
and support any Bitcoin Snap, but it doesn't need to be handled now in this PR.
Closed in favor of #27964 |
Builds ready [4aeb917]
Page Load Metrics (1998 ± 117 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR enables the send feature for
@metamask/bitcoin-wallet-snap
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/564
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist