Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BTC send flow #27964

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: add BTC send flow #27964

merged 1 commit into from
Oct 18, 2024

Conversation

montelaidev
Copy link
Contributor

Description

This PR enables the send feature for @metamask/bitcoin-wallet-snap

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/564

Manual testing steps

  1. Create a btc account
  2. Switch to the btc account
  3. Click send

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@montelaidev montelaidev self-assigned this Oct 18, 2024
@montelaidev montelaidev requested a review from a team as a code owner October 18, 2024 14:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@montelaidev montelaidev mentioned this pull request Oct 18, 2024
7 tasks
Copy link

socket-security bot commented Oct 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/bitcoin-wallet-snap@0.8.1 network 0 1.63 MB metamaskbot

🚮 Removed packages: npm/@metamask/bitcoin-wallet-snap@0.7.0

View full report↗︎

Copy link

socket-security bot commented Oct 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/bitcoin-wallet-snap@0.8.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@montelaidev
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/bitcoin-wallet-snap@0.8.1

New snap version

@danroc danroc changed the title feat: new btc send feat: add BTC send flow Oct 18, 2024
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was only able to partially test the flow since the fees are way too high right now on testnet.

We did run this branch against the E2E test (still WIP for now) though. 👍

@metamaskbot
Copy link
Collaborator

Builds ready [5ff534d]
Page Load Metrics (1978 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33625171796539259
domContentLoaded164923831944233112
load165825831978251121
domInteractive26210554019
backgroundConnect8264395527
firstReactRender852991144723
getState4213254723
initialActions01000
loadScripts11851795144518890
setupStore1097343014
uiStartup181031382243364175
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 13 Bytes (0.00%)
  • common: 387 Bytes (0.00%)

@ccharly ccharly added this pull request to the merge queue Oct 18, 2024
Merged via the queue into develop with commit 7ae2c94 Oct 18, 2024
84 of 85 checks passed
@ccharly ccharly deleted the feat/btc-send-2 branch October 18, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Oct 18, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.8.0 Issue or pull request that will be included in release 12.8.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants